Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91970
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.179 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXbgoFZD5-YFz3M9sNDy6C1g3J7+JJNAzj_dUJ3QVwPf1A@mail.gmail.com>
References: <CAF+90c_Qi6=iQK=wjCBUreMmt9KiUyh3bZfn_roTJDEC-++EBg@mail.gmail.com>
	<CAKws9z2iMp33XmFZdshAgWX07J3Yh41cDV73CyEBh2pOceNFkg@mail.gmail.com>
	<CADyq6sLdsT2k=L-ZYEZUP7N4uSFvUday21wkN2kSzPFePo3Row@mail.gmail.com>
	<CAGa2bXbPXWkwsswOMJ3i14KP-ej_HWABbJkHyeO43HVgd4c34w@mail.gmail.com>
	<CADyq6sLzgfBT_6LkLvSS92+YJnKKgSw5XBk8JbL5Z6cuaUjZCw@mail.gmail.com>
	<CAGa2bXbQ++K6fpWsfwD=iLLxABo27Am41yUCFmSEoB67gGk9fQ@mail.gmail.com>
	<CAGa2bXbgoFZD5-YFz3M9sNDy6C1g3J7+JJNAzj_dUJ3QVwPf1A@mail.gmail.com>
Date: Sun, 27 Mar 2016 22:22:40 +0200
Message-ID: <CAF+90c9ERigdmtA__Uh2MY=aJgOhWrFjWhLcyEA8eFgJ=S=YfQ@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: Marco Pivetta <ocramius@gmail.com>, Scott Arciszewski <scott@paragonie.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1141e7f4ce2728052f0d8ec2
Subject: Re: [PHP-DEV] Allow empty property names
From: nikita.ppv@gmail.com (Nikita Popov)

--001a1141e7f4ce2728052f0d8ec2
Content-Type: text/plain; charset=UTF-8

On Sat, Mar 26, 2016 at 12:17 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> On Sat, Mar 26, 2016 at 8:08 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> > On Sat, Mar 26, 2016 at 8:00 AM, Marco Pivetta <ocramius@gmail.com>
> wrote:
> >> On 25 March 2016 at 23:56, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> >>>
> >>> Hi all,
> >>>
> >>> On Sat, Mar 26, 2016 at 5:31 AM, Marco Pivetta <ocramius@gmail.com>
> wrote:
> >>> > var_dump((object) ['' => 'foo']);
> >>> > var_dump((object) ["\0*\0" => 'foo']);
> >>> > var_dump((object) ["\0Foo\0" => 'foo']);
> >>>
> >>> Allowing null char would be too much. We reject null char in path
> >>> parameters, it should be rejected like path parameter. IMHO.
> >>
> >>
> >> The sequence "\0*\0" means "protected property", while the sequence
> >> "\0Foo\0" means "private property of class Foo": that's been the case
> for a
> >> looooong time :-)
> >
> > Oh. Was it? I've never used and encountered this. Thanks.
> > I'll avoid null char as I use PostgreSQL JSONB extensively, though.
> >
> >> Not suggesting allowing "\0" for property names: the example just shows
> >> creating a public, private and protected property with an empty name.
> >
> > Could you show some real world example use cases?
>
> You mean PHP converts private/protected property to this form, not
> currently used as JSON string.
> I understand your point!
>
> It would be good for PHP users supporting null chars in names, then.
>

As the discussion seems to going off on a tangent I'd like to clarify: I'm
only suggesting to remove the restriction on empty property names. The
restrictions we have on properties starting with NUL bytes stay intact, as
these do serve a purpose with regard to name mangling.

To add one further data point, dropping the empty property restriction also
fixes this bug about returning an array with an empty key from
__debugInfo(): https://bugs.php.net/bug.php?id=69537

Nikita

--001a1141e7f4ce2728052f0d8ec2--