Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91956
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.52 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CADyq6sLdsT2k=L-ZYEZUP7N4uSFvUday21wkN2kSzPFePo3Row@mail.gmail.com>
References: <CAF+90c_Qi6=iQK=wjCBUreMmt9KiUyh3bZfn_roTJDEC-++EBg@mail.gmail.com>
 <CAKws9z2iMp33XmFZdshAgWX07J3Yh41cDV73CyEBh2pOceNFkg@mail.gmail.com> <CADyq6sLdsT2k=L-ZYEZUP7N4uSFvUday21wkN2kSzPFePo3Row@mail.gmail.com>
Date: Sat, 26 Mar 2016 07:56:59 +0900
Message-ID: <CAGa2bXbPXWkwsswOMJ3i14KP-ej_HWABbJkHyeO43HVgd4c34w@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Scott Arciszewski <scott@paragonie.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Allow empty property names
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi all,

On Sat, Mar 26, 2016 at 5:31 AM, Marco Pivetta <ocramius@gmail.com> wrote:
> var_dump((object) ['' => 'foo']);
> var_dump((object) ["\0*\0" => 'foo']);
> var_dump((object) ["\0Foo\0" => 'foo']);

Allowing null char would be too much. We reject null char in path
parameters, it should be rejected like path parameter. IMHO.

Postgresql decided not to allow null char as valid unicode string in
JSONB, for example.
http://www.postgresql.org/docs/9.4/static/datatype-json.html

 The jsonb type also rejects \u0000 (because that cannot be
represented in PostgreSQL's text type)

Postgresql has it own reason why null char cannot be supported. PHP
may suppport it., but I'm 30/70 for supporting null char in property
name because I cannot think of any use cases other than attacking
applications. (BTW, null char in data should be supported as it is
now)

Array key supports binary strings. If there is vote for this change, I
would refrain from voting.
php > var_dump(["abc\0xyz"=>1234]);
php shell code:1:
array(1) {
  'abc\0xyz' =>
  int(1234)
}


var_dump($o->{'123Foo'}); works. ($o->123Foo is illegal)
Therefore, +1 for making $o->{''} to work and removing automatic '' ->
'_empty_' conversion.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net