Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91867
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain devilix.net designates 209.85.214.170 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <56F19BB9.7030703@gmail.com>
References: <CAKws9z0ahvvd8z=Y5nSH8EmZPgA-6VMmOMsrc-SZSaPGb28Y-g@mail.gmail.com>
	<CAF+90c_im1igitq9UJRXQ7UknmOSbE-_b_+bGpKvgAZd6585_w@mail.gmail.com>
	<CAKws9z0a4wf=_K2gTsw7yptMvn9mHkmu5dpYwPpMTzTJ6PKzTA@mail.gmail.com>
	<56F19BB9.7030703@gmail.com>
Date: Tue, 22 Mar 2016 21:33:56 +0200
Message-ID: <CAPhkiZxis3gVMrO0=OdOHUizeahmJZHCzb+hLxRo6YT3apj-Yw@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: Scott Arciszewski <scott@paragonie.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=047d7b2e41da4afaf6052ea84b65
Subject: Re: [PHP-DEV] [RFC][VOTE] Deprecate then Remove Mcrypt Closed (23-6)
From: narf@devilix.net (Andrey Andreev)

--047d7b2e41da4afaf6052ea84b65
Content-Type: text/plain; charset=UTF-8

Hi,

On Tue, Mar 22, 2016 at 9:23 PM, Stanislav Malyshev <smalyshev@gmail.com>
wrote:

> Hi!
>
> > be in the spirit of what was voted on to keep it (at least as an alias
> for
> > random_bytes()). However, that was not covered by what everyone voted
> for.
> > How would you like to proceed?
>
> I'd say keep it - either as an alias of as a function, doesn't matter.
> It looks like common sense BC measure and doesn't seem to hurt anything.
> If we'll be moving whole extension out to PECL, we could keep this
> particular function as an alias.
>
>
While keeping it as an alias wouldn't be the worst thing ... I disagree,
exactly because the whole extension is moved to PECL.

mcrypt isn't an extension enabled by default and I'm yet to see a piece of
code that doesn't do one of the following checks before calling
mcrypt_create_iv():

- function_exists('mcrypt_create_iv')
- extension_loaded('mcrypt')
- defined('MCRYPT_DEV_URANDOM') // or another MCRYPT_* constant

Unless of course it's a part of a library that explicitly depends on
ext/mcrypt being enabled.

So ... I don't see this alias really helping more than a handful of people.

Cheers,
Andrey.

--047d7b2e41da4afaf6052ea84b65--