Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:91832 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 51929 invoked from network); 21 Mar 2016 23:35:16 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 21 Mar 2016 23:35:16 -0000 Authentication-Results: pb1.pair.com header.from=dz@heroku.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=dz@heroku.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain heroku.com designates 74.125.82.42 as permitted sender) X-PHP-List-Original-Sender: dz@heroku.com X-Host-Fingerprint: 74.125.82.42 mail-wm0-f42.google.com Received: from [74.125.82.42] ([74.125.82.42:38610] helo=mail-wm0-f42.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 44/D0-46740-33580F65 for ; Mon, 21 Mar 2016 18:35:16 -0500 Received: by mail-wm0-f42.google.com with SMTP id l68so141350272wml.1 for ; Mon, 21 Mar 2016 16:35:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=heroku-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=A97Ht9jfIbm4BO54buhXQKtVBeNUpl9VAj1+kxIWvyY=; b=mzsMVQmoiph2/yRWEHFnogfNM7uY61FFvSrC44NkmB34+oZE1+93PMn0ocHBLb5g+A fPYTZqOxloRCmf7THuhDe6+uHzdjiD1cXELbwmyISZAGDrcQmp3/rLfS6K4pgAeIwsHn rsGQRVYm1e75xEkw8lFwlCf0/IddaPv5cMclIk28XykkJ+3DkcsR8BOvjMIgdbggRXub iqpL7nVHpSGq0ul9GIko9TvKnt47hT0LU7ChH8O8/36rfN+6aqCS7PLC5ehGQyqt4vRW B5jAHL1emuciLgD8+YncqtMQFwFDetnwt1FK+W7pp2CZG3VSNLIqUSPeOAcqbfg+nSvm OkFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=A97Ht9jfIbm4BO54buhXQKtVBeNUpl9VAj1+kxIWvyY=; b=QRPmuR1ly957lG64tpdVC5HRlRvINJwwIye9YmtWqf1t0TU1N8yj7efU0M6Ta0hMz+ r+wLo689RF/beLyA3wo8RkxRv1pAz+ibyT/mgrDDgt18nrXrY+D8UvVIfhB1cFRWq+vu f9g2yda2ipLjvupnuxoOo/F7H1rQDHHKxeXB1xPfiaJSkPN5MOxaoesjMz6jsdf8Yshg YrjKvcGz5VDxSf2p0Pw1ST1D1UMPRjkiklGmSOVF1sdkZX5gvuYHcROEKGn/SaMaUG/E m/Njt1dpVaNU9NatXPmPMv5PILgXNgY89jgDMf9hePLx4se76wHYsneHjYu9RQ+8XWfA q9RQ== X-Gm-Message-State: AD7BkJKp9R5yP5U1EKONjaq2qrdYGZqz/ywfkPr78iZYDeCpHK5AEh76q3ugc9k3g6M0L3Af X-Received: by 10.194.48.111 with SMTP id k15mr36814766wjn.103.1458603313209; Mon, 21 Mar 2016 16:35:13 -0700 (PDT) Received: from [192.168.19.20] (ipb21b5588.dynamic.kabel-deutschland.de. [178.27.85.136]) by smtp.gmail.com with ESMTPSA id t3sm27496138wjz.11.2016.03.21.16.35.10 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 21 Mar 2016 16:35:11 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\)) In-Reply-To: <0ba501d183c3$2e604ee0$8b20eca0$@belski.net> Date: Tue, 22 Mar 2016 00:35:10 +0100 Cc: Christoph Becker , Pierre Joye , PHP internals , Nikita Popov Content-Transfer-Encoding: quoted-printable Message-ID: References: <55B0CADD.8000807@gmx.de> <55B136BE.8010006@gmx.de> <046401d0c644$9cf76880$d6e63980$@belski.net> <55B2B78A.4080202@gmx.de> <048001d0c665$ed19ec40$c74dc4c0$@belski.net> <55B2D779.9090409@gmx.de> <04d301d0c6e5$6b28f0c0$417ad240$@belski.net> <55B3B2E6.7080905@gmx.de> <056e01d0c7d9$b1edd990$15c98cb0$@belski.net> <55B559C7.9060304@gmx.de> <064301d0c85f$5260ac60$f7220520$@belski.net> <55C008B1.2050008@gmx.de> <05ec01d0ce97$4ee7c4e0$ecb74ea0$@belski.net> <55C09EE2.7010400@gmx.de> <063f01d0cec2$91b9baf0$b52d30d0$@belski.net> <55C0F908.2050708@gmx.de> <068e01d0cefb$6ffba3e0$4ff2eba0$@belski.net> <016e01d17ef7$cd8a2660$689e7320$@belski.net> <25D67B35-88FF-4A5C-9421-BAF482B32A96@heroku.com> <036501d17fc3$d51357e0$7f3a07a0$@belski.net> <5E36AA30-831F-44BE-A148-8720B8E87E96@heroku.com> <94A89B0F-48BB-4DD8-A26B-3B6D2C8C2C9F@heroku.com> <099201d182f1$3c954600$b5bfd200$@ belski.net> < 7 DF19331-9967-47C8-B21D-260C619BBD5E@heroku.com> <0b5101d183a1$5b38fdd0$11aaf970$@belski.net> <92DFDA3A-A52E-4435-BCC5-D67F855382AD@heroku.com> <0ba501d183c3$2e604ee0$8b20eca0$@belski.net> To: Anatol Belski X-Mailer: Apple Mail (2.3112) Subject: Re: [PHP-DEV] PCRE JIT stack size limit From: dz@heroku.com (David Zuelke) On 21.03.2016, at 23:44, Anatol Belski wrote: >=20 > What I'm suggesting to do is using a bit finer comb checking with the = real > life situations. Fe what would be the win for the user, either having = to > enable JIT by hand, or to disable it in a rare case. Currently, as for = me, > the latter seems still to be a more feasible option. At some point = some due > consideration could be reached, but I don't see the today's point as = such. > As long as we still handle over 99% of the usage cases with a simple = JIT > stack increase, it is IMHO more than balanced. The option of falling = back to > no JIT could be still kept in mind as it's most likely won't cause any > compatibility issue. Yeah no doubt. The trouble is that not always is the cause of the error = very clear. I'd guess most code out there doesn't use preg_last_error() = to figure out what went wrong and report that back, making it look like = there simply was no match, so there's likely a lot of unknown cases, of = which just some will emerge over time. What adds to the trouble is that it depends on the subject string, and = not just on the pattern. So maybe people's existing tests won't catch = it. How about defaulting JIT to off (or at least setting it to 0 in both the = recommended dev and prod INIs that ship with PHP) until an automatic = fallback has been implemented?