Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91791
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain heroku.com designates 74.125.82.51 as permitted sender)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.2 \(3112\))
In-Reply-To: <CAEKnhAE1SJn46Lpefih_vWyjiT4UjP4DGj4BNZD9B-0TGSZgiQ@mail.gmail.com>
Date: Sun, 20 Mar 2016 22:08:51 +0100
Cc: PHP internals list <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <6796160E-FAA7-42A3-953A-2D000F8BA294@heroku.com>
References: <CAEKnhAE1SJn46Lpefih_vWyjiT4UjP4DGj4BNZD9B-0TGSZgiQ@mail.gmail.com>
To: Jakub Zelenka <bukka@php.net>
Subject: Re: [PHP-DEV] OpenSSL ext status including port to OpenSSL 1.1
From: dz@heroku.com (David Zuelke)

On 20.03.2016, at 20:50, Jakub Zelenka <bukka@php.net> wrote:
>=20
> Hi,
>=20
> I just wanted to send a quick update about my recent work on openssl =
ext in
> case someone else wanted to start something similar so we don't have a
> wasted effort on that. :)
>=20
> 1. Error queueing
>=20
> I'm more or less done with a patch for error storing and clearing =
OpenSSL
> error queue:
>=20
> =
https://github.com/php/php-src/compare/PHP-7.0...bukka:openssl_error_store=


Good stuff! Just FYI, there has been decent progress on the discussion =
around how to make libpq behave better with openssl errors (that's what =
I think prompted this change originally by way of a ticket); looks like =
that'll land in the next point release(s). But since other extensions' =
libs may also use openssl, the same issue can arise again anytime, so =
storing the errors ourselves on the PHP side is a great change that =
fixes all (well, most of) those potential issues in one sweep.


> I have been slowly working on a more complete test for =
openssl_error_string
> that will cover most real error cases. There is still quite a lot of =
work
> that I need to do but the incomplete test can be seen here:
>=20
> =
https://github.com/bukka/php-util/blob/master/tests/openssl/openssl_error_=
string_basic.phpt
>=20
> The idea is that I would like to create a PR against 7.0 after I'm =
happy
> with that test so it can be tested by others and then merged. Then I =
plan
> to merge the AEAD work that is complete but overlaps slightly with =
this one
> so I want to merge it after that...

Any plans to port that back to 5.6 as well? I'd really love to see that, =
considering how it fixes real issues in the wild, and how long the =
security fix phase for 5.6 will be.


> 2. OpenSSL 1.1 port
>=20
> I have got a port of the extension to work on OpenSSL 1.1. There has =
been
> quite a bit of changes mainly due to the fact that most structures are =
now
> opaque (but also some other changes)

I assume 1.0.whatever-is-in-ubuntu will remain usable? Or do we plan on =
requiring 1.1 in, say, 7.1?

Thanks for all your hard work on this Jakub!

David