Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91785
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.176 as permitted sender)
Content-Type: text/plain; charset=koi8-r; format=flowed; delsp=yes
To: internals@lists.php.net
References: <CAKSD0w77DKKnOP2SzF3UPW-f84g2WDsUeQR-9Jt+sKwNxQ4yEw@mail.gmail.com> <BY2PR0201MB178477DE7DEA4468F7152AA0BF8C0@BY2PR0201MB1784.namprd02.prod.outlook.com> <CAKSD0w4XjWe7ptrEHGrfTXcR8LxYY+MKFVbXbH_1FN8wyFaUNg@mail.gmail.com> <44.0B.03097.E29BDE65@pb1.pair.com>
Date: Sun, 20 Mar 2016 11:52:05 +0300
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Message-ID: <op.yel783cfc9evq2@nikita-pc>
In-Reply-To: <44.0B.03097.E29BDE65@pb1.pair.com>
User-Agent: Opera Mail/12.17 (Win32)
Subject: Re: [PHP-DEV] Object getter method optimization
From: inefedor@gmail.com ("Nikita Nefedov")

On Sat, 19 Mar 2016 23:40:09 +0300, Andrea Faulds <ajf@ajf.me> wrote:

> Hi Lin,
>
> Lin Yo-An wrote:
>> Since the original approach doesn't work, here comes another new idea:
>>
>> When executing method call on an object, if we found the method body are
>> just 2 op codes (FETCH_OBJ_R and RETURN), we then denote the method is a
>> "getter method"
>>
>> And the next time, when we execute the same method, we found the "getter
>> method" flag, we simply execute FETCH_OBJ_R on that object and return  
>> the
>> value to avoid extra op code execution time.
>>
>> Do you think if this could work?
>
> For a while I'd also been wondering if we could implement some  
> implementation along these lines. Another approach could be possibly  
> replacing such methods with an C implementation (though I don't know if  
> non-internal classes can have internal methods).
>
> I don't know how successful it will be, but I'm interested to hear how  
> much improvement it gives if you get it working.
>
> Thanks!


I was playing with this idea sometime ago, it gives good performance boost  
for code like `for ($i = 0; $i < 100000; $i++) $a->getFoo();` but in the  
end of the day it's a very limited optimization.
If you abstract away from getters and say you want to optimize more and  
more small functions like this one, you end up realizing that what you're  
actually doing is what JIT compilation would do in a more generic way.