Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91645
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <321D2AE8-4C59-4739-9D8B-C3A55D5B7D8C@gmail.com>
References: <CAF+90c-EMQ41jmrdCKytMpB7hXQUEvQ8biCaZTgAEOw-4WpcQA@mail.gmail.com>
	<CAESVnVrm9_cxy_dJfmoYVEeJtoj0qVdA2d54A4x7KPJfFcbGmQ@mail.gmail.com>
	<321D2AE8-4C59-4739-9D8B-C3A55D5B7D8C@gmail.com>
Date: Sat, 12 Mar 2016 19:16:24 +0100
Message-ID: <CAF+90c8VK+gr1rgRa8m1La35i=xwm_rZXCtfFHoxGLHfm8kzbQ@mail.gmail.com>
To: "Paul M. Jones" <pmjones88@gmail.com>
Cc: Sara Golemon <pollita@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1144042c99646e052dde0b1f
Subject: Re: [PHP-DEV] Evaluate arguments of new for classes without constructors
From: nikita.ppv@gmail.com (Nikita Popov)

--001a1144042c99646e052dde0b1f
Content-Type: text/plain; charset=UTF-8

On Sat, Mar 12, 2016 at 6:54 PM, Paul M. Jones <pmjones88@gmail.com> wrote:

>
> > On Mar 12, 2016, at 11:27, Sara Golemon <pollita@php.net> wrote:
> >
> >> HHVM does not implement "new" in this way, they always evaluate the
> arguments.
> >>
> > Which, if it helps, means that we already know a lot of frameworks
> > /don't/ break as a result of fixing this behavior.
> >
> >> As this is technically a BC affecting change (even if of the lowest
> >> impact), I'm running it past the list first.
> >>
> > Technically a BC break that justifies waiting till a major version.
> > Given the extremely specific requirements to hit this edge case
> > however, passing side-effect args to a non-existent constructor, I
> > personally think a minor version is fine.
>
> Of curiosity, what effect (if any) might this have on
> ReflectionClass::newInstance(), ::newInstanceArgs(), and
> ::newInstanceWithoutConstructor()?  (I ask because some existing DI
> systems, such as Aura.Di, rely on those for creating objects.)


There is no effect on any the ReflectionClass::newInstance*() methods, only
direct use of the "new" operator is affected.

Nikita

--001a1144042c99646e052dde0b1f--