Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91624
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.52 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAJaRsPu+1-4smkTLACKFavHKqED0gBrz-w42wAVXvj-mYKHZNA@mail.gmail.com>
References: <CAJaRsPu+1-4smkTLACKFavHKqED0gBrz-w42wAVXvj-mYKHZNA@mail.gmail.com>
Date: Fri, 11 Mar 2016 07:56:46 +0900
Message-ID: <CAGa2bXYkcY6fOqUWmSK3JSw75huJR=wVKRbk+Ld8Pw0d2hNkCw@mail.gmail.com>
To: "Colin O'Dell" <colinodell@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC Discussion] "var" Deprecation
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi!

On Fri, Mar 11, 2016 at 2:14 AM, Colin O'Dell <colinodell@gmail.com> wrote:
> I have completed my initial draft of the RFC to deprecate "var" in favor of
> "public": https://wiki.php.net/rfc/var_deprecation
>
> I would greatly appreciate any feedback on this RFC, especially with the
> following:
>
> - Ensuring that all major arguments for & against have been documented.
> - Any impact this may have on SAPIs, extensions, or the opcache.
> - Any assistance or guidance on creating the patch (I've never written C or
> worked with the core codebase before).
>
> If you'd like to read the pre-draft discussion it can be found here:
> https://wiki.php.net/rfc/mailing_list_discussion

I'm 0 for this RFC, but providing upgrading script
https://gist.github.com/colinodell/5fb5e5d474674f294a38
is good approach for this kind of changes!
It works perfectly.

Good luck!

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net