Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:91601 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 16823 invoked from network); 9 Mar 2016 21:09:29 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 9 Mar 2016 21:09:29 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.213.47 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.213.47 mail-vk0-f47.google.com Received: from [209.85.213.47] ([209.85.213.47:32856] helo=mail-vk0-f47.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 05/1B-53667-70190E65 for ; Wed, 09 Mar 2016 16:09:27 -0500 Received: by mail-vk0-f47.google.com with SMTP id k1so71960181vkb.0 for ; Wed, 09 Mar 2016 13:09:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=7GUNEQpf1XA0k42Pd2HGuRksJ+vMxbkL3laoTIXE0IU=; b=Og8tDRauzBvp8eqmlpNJILQeAWnfKzudQkBNW2wVIBLgC6c4QqDMFi1C6FMFr2mVGY DXBJ5vCFc00Y8GNiymk2aDvB5QP8QFPqasCG3HE5DOZ1hTWwv3VWsqJ+8dRQDnGsLHzM tw1pnhDVWuHm5rt3F+Dga3bBz+233GiUQ04g5916K1dkVHDCG20PIqdAjTbol1C28caz rFw2rboYxoVdzrJFc+WvTKn3mvP4fMoZ+yXubK30ehR8FZBuRdIYX5fu/ibfl3GGclF7 fRIRiCB0C+7d9i7HJ6r95U9xMwPHyhaQccKdS90WpJxgCKDtq+zX5i3L+dRVpenYxk1i F7Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=7GUNEQpf1XA0k42Pd2HGuRksJ+vMxbkL3laoTIXE0IU=; b=MSJmdFbW6AtiLVgmg3f5yJ/RphKON4enj4EyAJLGqnC/XFY8onstb8dwv+Hyxt/zwP bD10CK9vOBOh5rk65z+OZTTIGbeWbZnMehgX0ozfCUwMS0tqvQnkhy9E2eQCu3yErPyr DD07hzuDIvxgVBcnrJ9VkM7JYe5oZGi4Rp38RDfwpU5W61oKeqG+TsMe7lX6P/tV59zb i5DwJImVUrwy5JGOgWlUfN4umNLc5rXK5Oam4qtz0TkrQjucy0KSkUIyAUid3nIvdJ5k ifCZ8j0GqIAYvKy0JX6Am/+KnMFo17WFslpnyg4gfNg6QPKMWexb9W68/3hwArdKiSa2 6mIQ== X-Gm-Message-State: AD7BkJI423WVUM6TfO2/UiHtr1/q/cNiQQhnf6vXV5vNcnJ9COdVm5QAoAaMRAVhQ6UM7O9w6ydoBIsWHsqp0A== X-Received: by 10.31.150.76 with SMTP id y73mr405925vkd.84.1457557764561; Wed, 09 Mar 2016 13:09:24 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.159.35.77 with HTTP; Wed, 9 Mar 2016 13:08:45 -0800 (PST) In-Reply-To: References: Date: Thu, 10 Mar 2016 06:08:45 +0900 X-Google-Sender-Auth: 1egcNkoKDwSIoAGDQbBVu7a-Yk4 Message-ID: To: Derick Rethans Cc: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] [RFC][VOTE] Precise session management From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Derick, On Wed, Mar 9, 2016 at 8:48 PM, Derick Rethans wrote: >> Hi all, >> >> This mail is for RFC vote notice. >> >> The RFC is >> https://wiki.php.net/rfc/precise_session_management >> The PR is >> https://github.com/php/php-src/pull/1734 >> >> I suppose almost all questions and discussion is finished, but >> if you have any, please comment/ask. >> >> Vote starts 2016-03-09-09:00(UTC) and ends 2016-03-23-09:00(UTC) >> https://wiki.php.net/rfc/precise_session_management#vote >> >> Please note that I set 2/3 of supporters is required to pass even if it >> is not strictly required. Please let us know the reason why if one >> would like to vote against this RFC. Thank you. > > Voted for, but I have added some comments to the PR. Thank you for comments. Session module returns FALSE for invalid status, therefore it would be better to return FALSE. IMO. However, this patch is for 7.1, so it can be changed. If we are going to change this, it would be nicer to change them all. I left some old changes in php.ini-*, these should be fixed. Thank you. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net