Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91589
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain webstart.fr from 209.85.161.172 cause and error)
MIME-Version: 1.0
Sender: pierrick@webstart.fr
In-Reply-To: <CADyq6sJvcir7je1RUzKyObgD5dSzkcwx9z1z84Bbm2=DF7Eueg@mail.gmail.com>
References: <CAOfKkdQ_9jQw5p6hcCx=YL-RoZWf4st8Q=C9hknHUzR97P0fhA@mail.gmail.com>
	<alpine.DEB.2.20.1603091149080.3594@whisky.home.derickrethans.nl>
	<CAOfKkdRWv8Z4z1bWHFHnX_EK=wQ-vxryy24731qnFhu7MHxRkw@mail.gmail.com>
	<CADyq6s+F1BpV9iksypM9-UKHxPoR8TJMBjomZz6cXM0msN6Egg@mail.gmail.com>
	<CAOfKkdT3H+Y7MsnOU6pdRokwBfHPqbf2fVfqrBZZjU0i4qwJLQ@mail.gmail.com>
	<CADyq6sJvcir7je1RUzKyObgD5dSzkcwx9z1z84Bbm2=DF7Eueg@mail.gmail.com>
Date: Wed, 9 Mar 2016 08:35:45 -0500
Message-ID: <CAOfKkdSi-ZP0-Oh6hVpHfbGpyaXeftfy7fybkQ-2q2LCtGOU-A@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Derick Rethans <derick@php.net>, PHP internals <internals@lists.php.net>, 
	=?UTF-8?B?QnJvbmlzxYJhdyBCaWHFgmVr?= <after89@gmail.com>
Content-Type: multipart/alternative; boundary=94eb2c08650e688a2a052d9dc687
Subject: Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types
From: pierrick@adoy.net (Pierrick Charron)

--94eb2c08650e688a2a052d9dc687
Content-Type: text/plain; charset=UTF-8

On 9 March 2016 at 08:30, Marco Pivetta <ocramius@gmail.com> wrote:

> On 9 March 2016 at 14:24, Pierrick Charron <pierrick@adoy.net> wrote:
>>
>> The thing I don't like about this approach is that I have to read the
>> code and double check to make sure that the catch statement call the same
>> method.
>> For the amount of work that needs to be done in the Engine (see the patch
>> attached to the RFC) this is far more readable and it is clear that the
>> code to handle those 3 exceptions is the exact same one. And if the code of
>> handleFailure is small you can even put it at this single place.
>>
>> public function stuff()
>> {
>>     try {
>>         $this->willFail();
>>     } catch (FirstException | SecondException | ThirdException $e) {
>>         $this->handleFailure($e);
>>     }
>> }
>>
>>
> I'd still have to write 3 test cases anyway: no real amount of
> code-savings there.
>

Agree


>
> I still think the first solution is as readable as the one you proposed
> there.
>

Agree to disagree ;-)


> The change in the PHP engine might be trivial, but the syntax change from
> a userland perspective is a mess (tooling, pretty much anything that relies
> on an AST parser needs changes there).
> Do not underestimate language changes as a php-core only issue.
>

You're right but I think those impact should not prevent us to make the
language evolve even for small changes that are just like this one
syntactic sugar. With the amount of user doing PHP code on a daily basis
those changes are IMO worth it.


>
> Marco Pivetta
>
> http://twitter.com/Ocramius
>
> http://ocramius.github.com/
>
>

--94eb2c08650e688a2a052d9dc687--