Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91588
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.173 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAOfKkdT3H+Y7MsnOU6pdRokwBfHPqbf2fVfqrBZZjU0i4qwJLQ@mail.gmail.com>
References: <CAOfKkdQ_9jQw5p6hcCx=YL-RoZWf4st8Q=C9hknHUzR97P0fhA@mail.gmail.com>
 <alpine.DEB.2.20.1603091149080.3594@whisky.home.derickrethans.nl>
 <CAOfKkdRWv8Z4z1bWHFHnX_EK=wQ-vxryy24731qnFhu7MHxRkw@mail.gmail.com>
 <CADyq6s+F1BpV9iksypM9-UKHxPoR8TJMBjomZz6cXM0msN6Egg@mail.gmail.com> <CAOfKkdT3H+Y7MsnOU6pdRokwBfHPqbf2fVfqrBZZjU0i4qwJLQ@mail.gmail.com>
Date: Wed, 9 Mar 2016 14:30:03 +0100
Message-ID: <CADyq6sJvcir7je1RUzKyObgD5dSzkcwx9z1z84Bbm2=DF7Eueg@mail.gmail.com>
To: Pierrick Charron <pierrick@adoy.net>
Cc: Derick Rethans <derick@php.net>, PHP internals <internals@lists.php.net>, 
	=?UTF-8?B?QnJvbmlzxYJhdyBCaWHFgmVr?= <after89@gmail.com>
Content-Type: multipart/alternative; boundary=001a114071b031beb4052d9db33a
Subject: Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types
From: ocramius@gmail.com (Marco Pivetta)

--001a114071b031beb4052d9db33a
Content-Type: text/plain; charset=UTF-8

On 9 March 2016 at 14:24, Pierrick Charron <pierrick@adoy.net> wrote:
>
> The thing I don't like about this approach is that I have to read the code
> and double check to make sure that the catch statement call the same method.
> For the amount of work that needs to be done in the Engine (see the patch
> attached to the RFC) this is far more readable and it is clear that the
> code to handle those 3 exceptions is the exact same one. And if the code of
> handleFailure is small you can even put it at this single place.
>
> public function stuff()
> {
>     try {
>         $this->willFail();
>     } catch (FirstException | SecondException | ThirdException $e) {
>         $this->handleFailure($e);
>     }
> }
>
>
I'd still have to write 3 test cases anyway: no real amount of code-savings
there.

I still think the first solution is as readable as the one you proposed
there.
The change in the PHP engine might be trivial, but the syntax change from a
userland perspective is a mess (tooling, pretty much anything that relies
on an AST parser needs changes there).
Do not underestimate language changes as a php-core only issue.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--001a114071b031beb4052d9db33a--