Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91585
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.178 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAOfKkdRWv8Z4z1bWHFHnX_EK=wQ-vxryy24731qnFhu7MHxRkw@mail.gmail.com>
References: <CAOfKkdQ_9jQw5p6hcCx=YL-RoZWf4st8Q=C9hknHUzR97P0fhA@mail.gmail.com>
 <alpine.DEB.2.20.1603091149080.3594@whisky.home.derickrethans.nl> <CAOfKkdRWv8Z4z1bWHFHnX_EK=wQ-vxryy24731qnFhu7MHxRkw@mail.gmail.com>
Date: Wed, 9 Mar 2016 14:08:11 +0100
Message-ID: <CADyq6s+F1BpV9iksypM9-UKHxPoR8TJMBjomZz6cXM0msN6Egg@mail.gmail.com>
To: Pierrick Charron <pierrick@adoy.net>
Cc: Derick Rethans <derick@php.net>, PHP internals <internals@lists.php.net>, 
	=?UTF-8?B?QnJvbmlzxYJhdyBCaWHFgmVr?= <after89@gmail.com>
Content-Type: multipart/alternative; boundary=001a11c37ad204989f052d9d657e
Subject: Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types
From: ocramius@gmail.com (Marco Pivetta)

--001a11c37ad204989f052d9d657e
Content-Type: text/plain; charset=UTF-8

On 9 March 2016 at 14:03, Pierrick Charron <pierrick@adoy.net> wrote:

> Hi Derick
>
> I agree that most of the time the best solution is to implement a clean
> exception hierarchy but as stated in the RFC :
>
> "A solution to fix this problem on the user level would be to implement a
> common interface for ExceptionType1 and ExceptionType2 and catch it.
> However, this is only possible when you control the exception hierarchy in
> your own code, but not possible when you don't control the code."
>

I understand the use-case, but I don't see it as a widespread scenario. In
most cases, I've been doing something like following:

public function stuff()
{
    try {
        $this->willFail();
    } catch (FirstException $e) {
        $this->handleFailure($e);
    } catch (SecondException $e) {
        $this->handleFailure($e);
    } catch (ThirdException $e) {
        $this->handleFailure($e);
    }
}

Even then, this is a rare eventuality, and as pointed out above, usually
fixed when wrapping exceptions correctly, if you have control over the
exception types).
Seems way below the 80/20 use-case to me, and introduces syntax changes as
well.

Cheers,

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--001a11c37ad204989f052d9d657e--