Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91583
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain kelunik.com from 81.169.146.217 cause and error)
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.20.1603091149080.3594@whisky.home.derickrethans.nl>
References: <CAOfKkdQ_9jQw5p6hcCx=YL-RoZWf4st8Q=C9hknHUzR97P0fhA@mail.gmail.com>
	<alpine.DEB.2.20.1603091149080.3594@whisky.home.derickrethans.nl>
Date: Wed, 9 Mar 2016 13:04:50 +0100
Message-ID: <CANUQDCimwoJjCzUKKQGag-WekYNk9nzhUaVvFsJTfxKppL82+g@mail.gmail.com>
To: Derick Rethans <derick@php.net>
Cc: Pierrick Charron <pierrick@adoy.net>, PHP Internals <internals@lists.php.net>, 
	=?UTF-8?B?QnJvbmlzxYJhdyBCaWHFgmVr?= <after89@gmail.com>
Content-Type: multipart/alternative; boundary=001a114b3d9442eb9d052d9c8132
Subject: Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types
From: me@kelunik.com (Niklas Keller)

--001a114b3d9442eb9d052d9c8132
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

2016-03-09 12:52 GMT+01:00 Derick Rethans <derick@php.net>:

> Hi!
>
> On Tue, 8 Mar 2016, Pierrick Charron wrote:
>
> > Bronis=C5=82aw Bia=C5=82ek and I would like to start a discussion about=
 allowing
> > multiple exception types to be caught in a single catch statement.
> >
> > https://wiki.php.net/rfc/multiple-catch
>
> Would it not be better, to have your Exceptions extend a common base
> class in this case? Or perhaps, which I think is even better, to have
> your Exception classes implement a common interface that you can catch
> against. That I believe should already work.
>

This assumes they're my exceptions and I can change the code. Doesn't work
with libraries having not that good exception structures or even leaking
their dependency's exceptions.


> What you are asking PHP users to do with a multiple catch like this, is
> to test in each catch's statement block to test for each class again.
>

No, usually it's enough that they're all extending Exception / Throwable.
You just can't catch Exception / Throwable, because that would catch all
exceptions. If you have a multi-catch, it doesn't matter which exception is
thrown and it's never checked, otherwise you'd use two blocks directly.

Regards, Niklas


> Neither the inheritence or implements options from the previous
> paragraph have that issue.
>
> cheers,
> Derick
>

--001a114b3d9442eb9d052d9c8132--