Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91564
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.217.171 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAOfKkdSXCH+Wpd19JcNRYpabWp5HZNvgRMWWMByd_KPuKBezXQ@mail.gmail.com>
References: <CAOfKkdQ_9jQw5p6hcCx=YL-RoZWf4st8Q=C9hknHUzR97P0fhA@mail.gmail.com>
	<56DF5B04.1080505@telia.com>
	<CAOfKkdSXCH+Wpd19JcNRYpabWp5HZNvgRMWWMByd_KPuKBezXQ@mail.gmail.com>
Date: Wed, 9 Mar 2016 08:05:05 +0100
Message-ID: <CADFypoqFkzShkVSJ+H0NtQqccJ7tub6r9KqMN_YF0RdoyVgrrQ@mail.gmail.com>
To: Pierrick Charron <pierrick@adoy.net>
Cc: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= <bjorn.x.larsson@telia.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1140c8ec4e98c9052d98515a
Subject: Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types
From: after89@gmail.com (=?UTF-8?B?QnJvbmlzxYJhdyBCaWHFgmVr?=)

--001a1140c8ec4e98c9052d98515a
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi :)

I think it is feature that is useful time to time, not very often.
One example:

class PackingFailed extends \Exception implements PackagingException {}

// this exception could originate from package with assertions/exceptions,
// so I cannot use common interface with above
class EmptyName extends \Exception implements ValidationException {}

class Packer
{
    /** @throws PackingFailed */
    public function pack(PackTemplate $packTemplate) : Pack
    {
        try {
            return $this->save($packTemplate);
        } catch (IOException $e) {
            throw new PackingFailed('', 0, $e);
        }
    }
}

class PackTemplate
{
    /** @throws EmptyName */
    public function __construct(string $name)
    {
        if ($name =3D=3D=3D '') {
            throw new EmptyName();
        }
    }
}

/** @throws SomeException */
function packeForMe(string $name) : Pack
{
    try {
        return (new Packer())->pack(new PackTemplate($name));
    } catch (PackingFailed | ValidationException $e) {
        throw new SomeException($e); // or return null in other cases
    }
}


2016-03-09 2:47 GMT+01:00 Pierrick Charron <pierrick@adoy.net>:

> Hi Bj=C3=B6rn,
>
> The only time I had to do this with core PHP exceptions is to make the
> code compatible for both PHP5 and PHP7:
>
> try {
> } catch(\Exceptions $e) {
> } catch(\Throwable $e) {
> }
>
> But it will of course not be applicable since this feature is targeting
> PHP7.1. Other than that the PHP core exception hierarchy is well enough f=
or
> MY needs. But if someone already had to do this fill free to provide your
> use case as an example.
>
> My main target is custom exceptions (even if the logic is applicable on
> everything Throwable). A custom exception use case would be some method
> that throw thwo different kind of exceptions like for example the doctrin=
e
> AbstractQuery::getSingleResult (NoResultException,
> NonUniqueResultException) that you could want to handle the same way.
>
> An other really easy example would be simple code like this one that I
> found in symfony (not really a big deal but still)
>
> } catch (AccessException $e) {
>     return false;
> } catch (UnexpectedTypeException $e) {
> return false;
> }
>
> And other piece of code using multiple libraries.
>
>
> On 8 March 2016 at 18:06, Bj=C3=B6rn Larsson <bjorn.x.larsson@telia.com> =
wrote:
>
>> Den 2016-03-08 kl. 22:42, skrev Pierrick Charron:
>>
>>> Hi internals,
>>>
>>> Bronis=C5=82aw Bia=C5=82ek and I would like to start a discussion about=
 allowing
>>> multiple exception types to be caught in a single catch statement.
>>>
>>> https://wiki.php.net/rfc/multiple-catch
>>>
>>> A working implementation and tests are available in the RFC.
>>>
>>> We are waiting for your constructive feedback and thoughts.
>>>
>>> Thanks
>>> Pierrick
>>>
>>> Nice RFC! Think it would be good if you had an example in the
>> RFC showing the applicability of catching two php exceptions.
>> Especially given the new exception hierarchy in PHP 7. I'm also
>> pondering if the main target for this is custom exceptions or
>> the built-in ones or both?
>>
>> Regards //Bj=C3=B6rn Larsson
>>
>> PS
>>
>
>


--=20
Pozdrawiam,
Bronis=C5=82aw Bia=C5=82ek.

--001a1140c8ec4e98c9052d98515a--