Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91562
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain webstart.fr from 209.85.160.179 cause and error)
MIME-Version: 1.0
Sender: pierrick@webstart.fr
In-Reply-To: <56DF5B04.1080505@telia.com>
References: <CAOfKkdQ_9jQw5p6hcCx=YL-RoZWf4st8Q=C9hknHUzR97P0fhA@mail.gmail.com>
	<56DF5B04.1080505@telia.com>
Date: Tue, 8 Mar 2016 20:47:43 -0500
Message-ID: <CAOfKkdSXCH+Wpd19JcNRYpabWp5HZNvgRMWWMByd_KPuKBezXQ@mail.gmail.com>
To: =?UTF-8?Q?Bj=C3=B6rn_Larsson?= <bjorn.x.larsson@telia.com>
Cc: =?UTF-8?B?QnJvbmlzxYJhdyBCaWHFgmVr?= <after89@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11352f8a4ef58a052d93e286
Subject: Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types
From: pierrick@adoy.net (Pierrick Charron)

--001a11352f8a4ef58a052d93e286
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Bj=C3=B6rn,

The only time I had to do this with core PHP exceptions is to make the code
compatible for both PHP5 and PHP7:

try {
} catch(\Exceptions $e) {
} catch(\Throwable $e) {
}

But it will of course not be applicable since this feature is targeting
PHP7.1. Other than that the PHP core exception hierarchy is well enough for
MY needs. But if someone already had to do this fill free to provide your
use case as an example.

My main target is custom exceptions (even if the logic is applicable on
everything Throwable). A custom exception use case would be some method
that throw thwo different kind of exceptions like for example the doctrine
AbstractQuery::getSingleResult (NoResultException,
NonUniqueResultException) that you could want to handle the same way.

An other really easy example would be simple code like this one that I
found in symfony (not really a big deal but still)

} catch (AccessException $e) {
    return false;
} catch (UnexpectedTypeException $e) {
return false;
}

And other piece of code using multiple libraries.


On 8 March 2016 at 18:06, Bj=C3=B6rn Larsson <bjorn.x.larsson@telia.com> wr=
ote:

> Den 2016-03-08 kl. 22:42, skrev Pierrick Charron:
>
>> Hi internals,
>>
>> Bronis=C5=82aw Bia=C5=82ek and I would like to start a discussion about =
allowing
>> multiple exception types to be caught in a single catch statement.
>>
>> https://wiki.php.net/rfc/multiple-catch
>>
>> A working implementation and tests are available in the RFC.
>>
>> We are waiting for your constructive feedback and thoughts.
>>
>> Thanks
>> Pierrick
>>
>> Nice RFC! Think it would be good if you had an example in the
> RFC showing the applicability of catching two php exceptions.
> Especially given the new exception hierarchy in PHP 7. I'm also
> pondering if the main target for this is custom exceptions or
> the built-in ones or both?
>
> Regards //Bj=C3=B6rn Larsson
>
> PS
>

--001a11352f8a4ef58a052d93e286--