Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91458
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.49 as permitted sender)
To: internals@lists.php.net
References: <1F.91.55238.41F10D65@pb1.pair.com>
 <CAHvhOfhYpnjkSjuo09TY7irhgW5UxNYZcWqtAr0iCcUAqJUgqw@mail.gmail.com>
 <CAKnqCEY7art1GUWG=Pm0wyPGQmYp0Dq8oxdohgBkSGq+O_BTZw@mail.gmail.com>
 <FA.10.10408.29514D65@pb1.pair.com>
Message-ID: <56D42CD3.6020602@gmail.com>
Date: Mon, 29 Feb 2016 11:34:43 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <FA.10.10408.29514D65@pb1.pair.com>
Content-Type: multipart/alternative;
 boundary="------------000901030801090503040502"
Subject: Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal
From: rowan.collins@gmail.com (Rowan Collins)

--------------000901030801090503040502
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

Tony Marston wrote on 29/02/2016 09:55:
> "James Titcumb"  wrote in message 
> news:CAKnqCEY7art1GUWG=Pm0wyPGQmYp0Dq8oxdohgBkSGq+O_BTZw@mail.gmail.com... 
>
>>
>> On 28 Feb 2016 06:18, "Jakub Kubícek" <kelerest123@gmail.com> wrote:
>>>
>>> I see a difference in its
>>> _semantics_. While the `public` modifier states anyone can change the
>>> property, `var` is useful for marking internal properties which must
>>> be public, but should not be manipulated by simply anybody
>>
>> If it's public, it will be modified by someone.
>
> Incorrect. It *may* be modified, but surely any invalid modifications 
> will be detected in the testing phase? 

Detected by whom? Using what tool? I'm not aware of any generic way of 
logging all access to particular properties, nor quite what "invalid 
modifications" mean in this labelling scheme. Maybe it would be detected 
during *review*? Apologies if that's what you meant and the distinction 
sounds pedantic.

A better way to mark this kind of distinction is using PHPDoc 
annotations, which can be made readable by both humans and tools. For 
instance, PHPStorm will cross through any uses of a property marked 
"@internal"; I wouldn't be surprised if other IDEs and tools can pick 
this up as well.

In this case, you could just use the fact that the property is labelled 
"@inject" to mark the distinction, and you'd be no worse off in terms of 
tooling support than you are now (i.e. IDEs will not come with this 
interpretation of "var" baked in anyway).

Regards,
-- 
Rowan Collins
[IMSoP]

--------------000901030801090503040502--