Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91455
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 65.55.169.131 as permitted sender)
To: Xinchen Hui <xinchen.h@zend.com>
References: <BY2PR0201MB178429DF6A3F3E5692C9C394BFA60@BY2PR0201MB1784.namprd02.prod.outlook.com>
 <CABBJUpdQKyWtQ0B1CBgrRZOcb4g3pm_kTCBHURb-YSxYkt_SMA@mail.gmail.com>
CC: "internals@lists.php.net" <internals@lists.php.net>, Nikita Popov
	<nikita.ppv@gmail.com>, Bob Weinand <bobwei9@hotmail.com>, Derick Rethans
	<derick@php.net>
Message-ID: <56D3F418.8000805@zend.com>
Date: Mon, 29 Feb 2016 10:32:40 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-Version: 1.0
In-Reply-To: <CABBJUpdQKyWtQ0B1CBgrRZOcb4g3pm_kTCBHURb-YSxYkt_SMA@mail.gmail.com>
Content-Type: multipart/alternative;
	boundary="------------080305020408010005050905"
SpamDiagnosticOutput: 1:23
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2016 07:32:52.9628 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0201MB1779
Subject: Re: [PHP-DEV] Change in internal call_user_function() API.
From: dmitry@zend.com (Dmitry Stogov)

--------------080305020408010005050905
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit



On 02/28/2016 05:01 AM, Xinchen Hui wrote:
> Hey:
>
> On Thu, Feb 25, 2016 at 11:16 PM, Dmitry Stogov <dmitry@zend.com 
> <mailto:dmitry@zend.com>> wrote:
>
>     Hi,
>
>
>     PHP-7.0 internal call_user_function() API doesn't support function
>     calls with preinitialised symbol tables.
>
>     This just can't work in general , because values of arguments
>     might be already initialized in CV as well as in symbol table.
>
>
>     I propose to remove the corresponding internal API in master:
>
>     1) remove last argument of call_user_function_ex()
>
>     2) remove zend_call_info.symbol_table field
>
>  I think it's okey,  (I assume this is for 7.1, right?)

Of course. Even for for 7.1 Nikita suggested to keep source level 
compatibility for call_user_function_ex(), and I agree with him.
I'll wait for Bob's response (phpdbg is, probably, the only one user if 
this broken feature), and then commit.

Thanks. Dmitry,
>
>  the value caller want to pass in should goes via arguments, which is 
> a more reasonable way.
>
> thanks
>
>
>
>     https://gist.github.com/dstogov/5550827aa695ff8cb803
>
>
>     The tricky way was used in phpdbg only, but that code doesn't
>     work, and should be fixed anyway.
>
>
>     Thanks. Dmitry.
>
>
>
>
> -- 
> Xinchen Hui
> @Laruence
> http://www.laruence.com/


--------------080305020408010005050905--