Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91436
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain schlueters.de from 217.114.215.10 cause and error)
Message-ID: <1456495810.5232.17.camel@kuechenschabe>
To: Andrea Faulds <ajf@ajf.me>
Cc: internals@lists.php.net
Date: Fri, 26 Feb 2016 15:10:10 +0100
In-Reply-To: <E6.23.55238.85730D65@pb1.pair.com>
References: 
	<CA+kxMuTHbsYAXe+J+jrFz+ZeguacEyUxCUpFJE8jMee_5+u_5g@mail.gmail.com>
	 <CADajX4DqjHUz9wxzKbC-oTgKQfz=zPZtNv_svY0OgxmhYwPiVA@mail.gmail.com>
	 <CA+kxMuTh6STM5jumLAXTY0Gz52CqZpYEw-xydS-wSZoi7-TdFg@mail.gmail.com>
	 <E6.23.55238.85730D65@pb1.pair.com>
Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature";
	boundary="=-dczmh2v/HlQXCcrTd+gR"
Mime-Version: 1.0
Subject: Re: [PHP-DEV] [RFC] Callable constructors
From: johannes@schlueters.de (Johannes =?ISO-8859-1?Q?Schl=FCter?=)

--=-dczmh2v/HlQXCcrTd+gR
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, 2016-02-26 at 11:30 +0000, Andrea Faulds wrote:
> This is true for a trivial implementation like the one above, but I=20
> would point out that a more sophisticated userland implementation could=
=20
> fix this by generating PHP code.


You don't have to generate PHP code for this to work:


$arr =3D is_string($func) ? explode("::", $func, 2) : $func;
$ref =3D (sizeof($arr) =3D=3D=3D 2) ?
   new ReflectionMethod($arr[0], $arr[1])
 : new ReflectionFunction($func);

$args =3D identifyArgumentsAndGetCtorArgs($ref);

if (sizeof($arr) =3D=3D=3D 2 && $arr[1] =3D=3D=3D '__construct') {
    $rc =3D new ReflectionClass($arr[0]);
    return $rc->newInstanceArgs($args);
} else {
    return $ref->invokeArgs($args);
}

I haven't tested this and it might need some fine tuning, but isn't
really complicated. (Of course you can generate PHP code for this
trivially in order to avoid the small reflection overhead)


> So it's still worth questioning whether this needs to be a built-in=20
> function.

I think it is quite obscure and a hardly used feature. Language features
and syntax sugar things should be common things.

johannes


--=-dczmh2v/HlQXCcrTd+gR
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQEcBAABAgAGBQJW0FzDAAoJEH3sTmn8nIPXYbMIALWfWyIzW91nRC0WvuSuJNr/
gWn/Z4ZjcpWvOEC1qUKUQJcMATR4bddPHKg1WZIhw8CeBdAcwFsOTyyeqtaVsNXb
4Fk+MGbbVisx4xivmw2eE/w74Y7peZUMbam7KYNAj2ZABiIbiy0uuGc/mcPUK9FO
Y8/OqxHeScThe6aj6N7YlLFOKU33lnC/wtm7TvYlRXJYX/dCKbaX79kAcMWv/N2+
y59KVxL7qcu+bxBXv/MCxqgGLJ3buLJzuiBpUIfC4R63k79GFDgD7ZR5tM8tMkLi
Az+qihVA1COLI6/pkBTXjcR39eTc/7LHKwPJC9yjoCHVDf2PNAGUkTNa/TInKgg=
=nMXp
-----END PGP SIGNATURE-----

--=-dczmh2v/HlQXCcrTd+gR--