Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91296
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 157.56.110.145 as permitted sender)
To: Andrea Faulds <ajf@ajf.me>
CC: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] Re: [RFC] Deprecations for PHP 7.1
Thread-Index: AQHRaoa7vYwtElySdku3mDia5FGqBp8yaXmH
Date: Thu, 18 Feb 2016 22:54:03 +0000
Message-ID: <3241F271-BDEC-4621-8697-D0352D6B92FE@zend.com>
References: <CAF+90c_1zO91x-4Madqm3F8gkKDT7jZKVZSbBuYMbnDCADrv_A@mail.gmail.com>,<24.F3.62769.A4226C65@pb1.pair.com>
In-Reply-To: <24.F3.62769.A4226C65@pb1.pair.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="windows-1255"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Feb 2016 22:54:04.0147
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB300
Subject: Re: [PHP-DEV] Re: [RFC] Deprecations for PHP 7.1
From: zeev@zend.com (Zeev Suraski)


> On 18 =E1=F4=E1=F8=D7 2016, at 21:58, Andrea Faulds <ajf@ajf.me> wrote:
>=20
>=20
> Hmm. Well, if we're doing mass deprecations, maybe we should finally get =
rid of hebrev() and hebrevc()? It feels out-of-place to have a poorly-docum=
ented standard library function specifically for converting between two dif=
ferent legacy 8-bit encodings used for Hebrew, especially when one of them =
is just the other with nl2br() included! Users who need to convert between =
different variants of ISO-8859-8 can use iconv() instead, or perhaps use a =
userland polyfill of hebrev/c().

I'm not aware that you can use iconv to convert visual to logical Hebrew or=
 vice versa.  Not saying you can't, just that I'm not aware it does - I don=
't think it support visual encodings at all.  Do you know how to convert be=
tween them using iconv?  If you do, I'm fine reimplementing these functions=
 using iconv, again, if we can eliminate the pointless upgrade hassle.  The=
 other alternative of a userland version isn't that simple to write, would =
be slower, and most importantly buys us nothing.


I'm guessing that hebrevc() predates nl2br() (could be wrong), but regardle=
ss, I wouldn't touch it as there's zero gain to be had.

Last - we're not or at least shouldn't be doing mass deprecations.  There s=
hould be an extremely strong reason to break perfectly good code.

Zeev=