Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91234
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.171 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAEZPtU6ujYs7+XyGqpUun6KCHR2efxfk71=phf=7SPg2XaEoPA@mail.gmail.com>
References: <56A3A01F.1020500@php.net> <56BC988F.7080101@php.net>
 <D9.BC.25203.806BCB65@pb1.pair.com> <56BD1CD4.8070206@php.net>
 <CAF+90c89n8pDCh4O3J5DBTao_8+1ON0TnJTxg-GbbROPorFyGg@mail.gmail.com>
 <56C14AC6.7060307@gmail.com> <CAGa2bXYv0GLweN10Y1w4oGqFwE_6-w-Dh6+yusGUs85GRfUMzg@mail.gmail.com>
 <CAEZPtU6ujYs7+XyGqpUun6KCHR2efxfk71=phf=7SPg2XaEoPA@mail.gmail.com>
Date: Mon, 15 Feb 2016 16:10:30 +0900
Message-ID: <CAGa2bXYJc=3Y8BRVH65Uix_hLw4_T_CVfx=dguBaYLr5_b=fsQ@mail.gmail.com>
To: Pierre Joye <pierre.php@gmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, Andrea Faulds <ajf@ajf.me>, 
	Stanislav Malyshev <smalyshev@gmail.com>, =?UTF-8?Q?Fran=C3=A7ois_Laupretre?= <francois@php.net>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] [RFC] Generalize support of negative string offsets
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi Pierre,

On Mon, Feb 15, 2016 at 4:01 PM, Pierre Joye <pierre.php@gmail.com> wrote:
> On Feb 15, 2016 1:15 PM, "Yasuo Ohgaki" <yohgaki@ohgaki.net> wrote:
>>
>> Hi all,
>>
>> On Mon, Feb 15, 2016 at 12:49 PM, Stanislav Malyshev
>> <smalyshev@gmail.com> wrote:
>> >> Another issue mentioned in this thread is the spurious array conversion
>> >> that happens for empty strings. We have an existing bug report for
>> >> this:
>> >> https://bugs.php.net/bug.php?id=53432 I've created a PR to fix this
>> >> issue: https://github.com/php/php-src/pull/1764 If there are no
>> >> objections, I'll merge this for 7.1 as well.
>> >
>> > This one looks like a bug, converting string to array is really weird.
>> > And one more reason to never use [] for string offsets - clearly, the
>> > bug stems out of confusion between arrays operation (which expects
>> > conversion to array) and string operation (which expects string).
>> > In any case, this needs a note in UPGRADING as behavior change.
>>
>> I fully agree {} and [] usage.
>>  - {} only for string
>>  - [] only for array
>> Simple is better if it satisfies all of our needs.
>>
>> Since PHP allowed [] for strings, how about allow it, but deprecate it
>> by doc in 7.1, deprecate(Raise error) it in 7.2, then remove it by
>> 7.3?
>
> If anything then it can be removed by 8.

Good enough for me!

--
Yasuo Ohgaki
yohgaki@ohgaki.net