Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91230
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.161.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <56BD1CD4.8070206@php.net>
References: <56A3A01F.1020500@php.net>
	<56BC988F.7080101@php.net>
	<D9.BC.25203.806BCB65@pb1.pair.com>
	<56BD1CD4.8070206@php.net>
Date: Sun, 14 Feb 2016 18:42:50 +0100
Message-ID: <CAF+90c89n8pDCh4O3J5DBTao_8+1ON0TnJTxg-GbbROPorFyGg@mail.gmail.com>
To: =?UTF-8?Q?Fran=C3=A7ois_Laupretre?= <francois@php.net>
Cc: Andrea Faulds <ajf@ajf.me>, PHP internals <internals@lists.php.net>, 
	Stanislav Malyshev <smalyshev@gmail.com>
Content-Type: multipart/alternative; boundary=001a11408daee352f4052bbe6dcb
Subject: Re: [PHP-DEV] [RFC] Generalize support of negative string offsets
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11408daee352f4052bbe6dcb
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 12, 2016 at 12:44 AM, Fran=C3=A7ois Laupretre <francois@php.net=
>
wrote:

> Le 11/02/2016 17:25, Andrea Faulds a =C3=A9crit :
>
>> Hi Fran=C3=A7ois,
>>
>> Fran=C3=A7ois Laupretre wrote:
>>
>>> String offsets are full of oddities :
>>>
>>> $str =3D "abc";
>>> $str{0} =3D '';
>>> var_dump($str); // -> string(3) "bc" (read as "\0bc")
>>>
>>> Assigning an empty string to a string offset inserts a null byte becaus=
e
>>> the string length is not checked in zend_assign_to_string_offset().
>>>
>>> I see this as a bug. IMO, this case should raise a warning and the
>>> string should remain unchanged.
>>>
>>> Thoughts before I register a bug and a PR ?
>>>
>>
>> Wow, that's quite egregious. I think this should be considered a bug and
>> fixed as soon as possible. Whether it should go into 7.0.x or 7.1 is
>> possibly a matter for debate, though.
>>
>> Thanks
>>
>>
> OK. Bug registered (https://bugs.php.net/bug.php?id=3D71572) along with P=
R (
> https://github.com/php/php-src/pull/1761).
>
> Can someone please review/merge the PR and close the bug ?
>

This fix has been merged into master (targeting 7.1), thanks!

Another issue mentioned in this thread is the spurious array conversion
that happens for empty strings. We have an existing bug report for this:
https://bugs.php.net/bug.php?id=3D53432 I've created a PR to fix this issue=
:
https://github.com/php/php-src/pull/1764 If there are no objections, I'll
merge this for 7.1 as well.

Nikita

--001a11408daee352f4052bbe6dcb--