Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91076
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.45 as permitted sender)
To: internals@lists.php.net
References: <CANaX5nf4eDSVaYg=HygRO-vK7r9yAvdhzoTUOFHT1LHUjpQjgw@mail.gmail.com>
 <CA+kxMuQCXB2VssedW9E=kvB4UfM+VbkWFHAZ4BFz9O7cWZA5Ag@mail.gmail.com>
 <56B233C0.10301@mprelu.de>
 <CAESVnVo6dM2N4KuA144pWkGe53ggy_rRF690QViVX5hmCc5D5Q@mail.gmail.com>
 <CANaX5ncq5JX704G66wWcYOWMKDkkd=CqQuEQ2DT5a32qiM1P0A@mail.gmail.com>
 <216F291E-F174-4E07-B650-DC9A63C07F61@fredemmott.co.uk>
Message-ID: <56B32943.4080305@gmail.com>
Date: Thu, 4 Feb 2016 10:34:43 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <216F291E-F174-4E07-B650-DC9A63C07F61@fredemmott.co.uk>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] [RFC] Add PHP_ENGINE Constant
From: rowan.collins@gmail.com (Rowan Collins)

Fred Emmott wrote on 03/02/2016 22:14:
>> On Feb 3, 2016, at 2:00 PM, Davey Shafik <davey@php.net> wrote:
>>
>> On Wednesday, February 3, 2016, Sara Golemon <pollita@php.net <mailto:pollita@php.net>> wrote:
>>
>> Unfortunately Sara, the types of things you generally have to work around
>> are minor things, like differences in DOM, or the inability to json_encode
>> DateTimeImmuteable
>
> It seems like the main thing this RFC would change is that you could easily do “if ($engine !== ‘php’)” - but for almost all the examples I can think of, and yours, what’s actually needed is if "($engine === ‘specific_engine_that_needs_a_workaround’)”, so I don’t see a benefit over using HHVM_VERSION or similar.
>
> The one exception I can think of is if someone’s reimplementing phpinfo() or similar.

Maybe what's actually needed is not something in the PHP spec itself, 
but a PHP equivalent of modernizr (https://modernizr.com/) - a library 
with a set of feature detections which bypass the whole question of 
"real PHP" or needing to know the exact quirks of every implementation. 
It would also be much easier to maintain and extend if it existed 
outside of any implementation, rather than needing every implementation 
to keep up with a growing list of requirements [first feature to detect: 
is the feature detection API present? ;)]

It could perhaps take the form of a set of unit tests which you run as 
part of a build process that then writes out a profile of the current 
environment. This would allow you to detect even things which cause 
fatal errors on some implementations, by triggering the error in a 
sub-process, and would be more efficient than probing them at runtime.

Regards,
-- 
Rowan Collins
[IMSoP]