Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:91071
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain daveyshafik.com from 209.85.161.171 cause and error)
MIME-Version: 1.0
Sender: me@daveyshafik.com
In-Reply-To: <216F291E-F174-4E07-B650-DC9A63C07F61@fredemmott.co.uk>
References: <CANaX5nf4eDSVaYg=HygRO-vK7r9yAvdhzoTUOFHT1LHUjpQjgw@mail.gmail.com>
	<CA+kxMuQCXB2VssedW9E=kvB4UfM+VbkWFHAZ4BFz9O7cWZA5Ag@mail.gmail.com>
	<56B233C0.10301@mprelu.de>
	<CAESVnVo6dM2N4KuA144pWkGe53ggy_rRF690QViVX5hmCc5D5Q@mail.gmail.com>
	<CANaX5ncq5JX704G66wWcYOWMKDkkd=CqQuEQ2DT5a32qiM1P0A@mail.gmail.com>
	<216F291E-F174-4E07-B650-DC9A63C07F61@fredemmott.co.uk>
Date: Wed, 3 Feb 2016 17:29:53 -0500
Message-ID: <CANaX5neqdCG=MkWppTGM=CWhP9pLirJoyRkK5QDBOevHAt3ssg@mail.gmail.com>
To: Fred Emmott <fred@fredemmott.co.uk>
Cc: Sara Golemon <pollita@php.net>, Matt Prelude <me@mprelu.de>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=94eb2c0b752e364491052ae528b7
Subject: Re: [PHP-DEV] [RFC] Add PHP_ENGINE Constant
From: davey@php.net (Davey Shafik)

--94eb2c0b752e364491052ae528b7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Currently, HippyVM doesn't even _have_ a version constant. Because it's
trying to pretend to be PHP. Having a "YOU MUST FILL THESE CONSTANTS WITH
YOUR OWN RUNTIMES DATA" in the spec is intended to help that situation.

Right now, there's no way to tell what version of HippyVM you're running
on, and to even check that you're using Hippy you need to check for
E_HIPPY_WARN.

We have a chance to standardize, and "mandate" that the information is
exposed explicitly, and done so consistently.

On Wed, Feb 3, 2016 at 5:14 PM, Fred Emmott <fred@fredemmott.co.uk> wrote:

>
> On Feb 3, 2016, at 2:00 PM, Davey Shafik <davey@php.net> wrote:
>
> On Wednesday, February 3, 2016, Sara Golemon <pollita@php.net> wrote:
>
> Unfortunately Sara, the types of things you generally have to work around
> are minor things, like differences in DOM, or the inability to json_encod=
e
> DateTimeImmuteable
>
>
>
> It seems like the main thing this RFC would change is that you could
> easily do =E2=80=9Cif ($engine !=3D=3D =E2=80=98php=E2=80=99)=E2=80=9D - =
but for almost all the examples I can
> think of, and yours, what=E2=80=99s actually needed is if "($engine =3D=
=3D=3D
> =E2=80=98specific_engine_that_needs_a_workaround=E2=80=99)=E2=80=9D, so I=
 don=E2=80=99t see a benefit over
> using HHVM_VERSION or similar.
>
> The one exception I can think of is if someone=E2=80=99s reimplementing p=
hpinfo()
> or similar.
>
> Regards,
>  - Fred
>

--94eb2c0b752e364491052ae528b7--