Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:91003 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 71774 invoked from network); 28 Jan 2016 23:16:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jan 2016 23:16:50 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.178 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.160.178 mail-yk0-f178.google.com Received: from [209.85.160.178] ([209.85.160.178:33654] helo=mail-yk0-f178.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id F1/02-53831-161AAA65 for ; Thu, 28 Jan 2016 18:16:49 -0500 Received: by mail-yk0-f178.google.com with SMTP id k129so50378456yke.0 for ; Thu, 28 Jan 2016 15:16:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=1PjKcG822UdOeChEeDcHqqm3Q/hlrr0sGsQD7ypxkxA=; b=ay8lPeIuY+e5ugryczptv4dVkPOkZf9+hX3C91gaqmE46z+gVu0knHXR9ir4xN0zaF sllAdnjxLQAN9i0B9y5iQrTTGGhg6uAlLgd4d88UoAoQMZF/FQUiaG2QPR81qKtX5A/v ySxcmTg6mKBhcu7+biyohQkUAZbYF9z4v5UOe1eHJYj/GzIko67fhkL2/Joy6oUAxwMm I3c5xmXd4WGbweUtOqukQ09ltA2XAMF2ESVU5cic57Ib/Gh85QS8o7BnpEYIdpPAIVoE DhWMx2tVYrmeL5DJF+bGcAyqVap0jFhTFwV/Ic5u9+wnnd4o98dciObsLdkSncx/sxKm Riag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:content-type; bh=1PjKcG822UdOeChEeDcHqqm3Q/hlrr0sGsQD7ypxkxA=; b=AX/Wb5n2+qiz6Ymj9dMmAjoS9rOoddc30TgttJvYpyvc6tlOWz42qLyVFfzXLObb77 RGUZPU4rzdFGgE1uM5cNy7Bu7K6JsKZxMp3neMAs+zxmgskj+pluOvV2SDPHhLgmtfnb A+seDj/p2w9JG3mgi+CHuNWnZ25NbYNU3k5T0nFLkLRzu6IlDR58QkhYrRAjgv+g8ARc ZCJcw08qSx11oFpbafz7FK9Xd+sJDwdiqeqW/5WcYaWa9abiRYJW56X/o71Nwx3gXzQo MBbB2+COOVDcuk91OXN2/9WaQV7SAoeWX3m8VGMYQubYSC9TMdBpArIoyqppp7Z3PcnH zgDQ== X-Gm-Message-State: AG10YOTXrk5wpB5CBPz8zcUWx6lCDPNYAM2hHvsUummJw5bQbfSIxcDcwgL9Zy04TVjLjH9nAfCCDt74KTbLvg== X-Received: by 10.37.230.133 with SMTP id d127mr2954797ybh.134.1454023006166; Thu, 28 Jan 2016 15:16:46 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.129.88.139 with HTTP; Thu, 28 Jan 2016 15:16:06 -0800 (PST) In-Reply-To: References: Date: Fri, 29 Jan 2016 08:16:06 +0900 X-Google-Sender-Auth: u54-NEZ0bAFqvyDJjrDlMJQGwQg Message-ID: To: Anatol Belski , "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: PR1739 From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Anatol, On Thu, Jan 28, 2016 at 1:33 PM, Yasuo Ohgaki wrote: > On Thu, Jan 28, 2016 at 12:48 PM, Yasuo Ohgaki wrote: >> >> https://github.com/php/php-src/pull/1739 >> This PR is good one. It opens handler first, then proceeds. >> It fixes save handler crash also. >> >> The PR does not break our tests and PHP7 only fix. However, It changes >> handler execution order. This change will not affect normal >> operation/code at all, but user's unit tests may detect the difference >> as we had already. >> >> Would you like to include this PR in released version? >> My opinion is +1 for applying this. > > It's committed to master > 46d4a371054f43fe8aeca14b83ba722adc84ac10 > > If you decide merge it, please cherry pick. > Thank you. I missed to include my error message change 99101ba31019e3b19e4cf3feaf163aeffb8a398c In case you pick up this. Please pick this, too. I made patch for work around patch. https://gist.github.com/yohgaki/2a19756978837e4dd07c It's a little dirty compare to master fix, but this works also. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net