Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90989
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain zend.com designates 157.56.111.136 as permitted sender)
To: Andrea Faulds <ajf@ajf.me>
CC: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [PHP-DEV] Re: [RFC] Warn about invalid strings in arithmetic
 (moving back todiscussion)
Thread-Index: AQHRWIGg/uFyFtZx8EimLakXWnIVaJ8QqOig
Date: Thu, 28 Jan 2016 09:25:37 +0000
Message-ID: <BY2PR02MB298A35C1435EEC50FBE0289ACDA0@BY2PR02MB298.namprd02.prod.outlook.com>
References: <55.70.56702.FD2E7A65@pb1.pair.com>
 <AF.C0.56702.9C6E7A65@pb1.pair.com>
In-Reply-To: <AF.C0.56702.9C6E7A65@pb1.pair.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: zend.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:23
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jan 2016 09:25:37.3669
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 32210298-c08b-4829-8097-6b12c025a892
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR02MB297
Subject: RE: [PHP-DEV] Re: [RFC] Warn about invalid strings in arithmetic
 (moving back todiscussion)
From: zeev@zend.com (Zeev Suraski)

> -----Original Message-----
> From: Andrea Faulds [mailto:ajf@ajf.me]
> Sent: Tuesday, January 26, 2016 11:36 PM
> To: internals@lists.php.net
> Subject: [PHP-DEV] Re: [RFC] Warn about invalid strings in arithmetic (mo=
ving
> back todiscussion)
>=20
> ...I proof-read my email, but I forgot the most important thing. The link=
!
>=20
> https://wiki.php.net/rfc/invalid_strings_in_arithmetic
>=20
> Sorry.
>=20
> Andrea Faulds wrote:
> > Good evening,
> >
> > I had opened the vote for this RFC, but then I was reminded by a
> > discussion in the pull request about a particular unresolved problem I
> > had forgotten about.
> >
> > In order to deal with that issue, I have cancelled the vote and
> > expanded the RFC (both in length and scope) to deal with it.
> >
> > The specific issue is detailed in a new section, "Fractional and
> > scientific notation strings with integer operators", but it affects
> > other sections as well.
> >
> > So, the RFC is back under discussion.
> >
> > Please read it and tell me your thoughts.

Andrea,

I think this is a good proposal.  Slightly worried about the E_NOTICE for t=
hings like "5px" + "10px", which I think are probably not uncommon, and wou=
ld have been better served by a separate E_STRICT, but that's no longer (pr=
actically) available.

Either way seems like a good idea.

Thanks,

Zeev