Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:90987 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 661 invoked from network); 28 Jan 2016 04:33:45 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jan 2016 04:33:45 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.172 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.160.172 mail-yk0-f172.google.com Received: from [209.85.160.172] ([209.85.160.172:35487] helo=mail-yk0-f172.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 8B/11-19998-82A99A65 for ; Wed, 27 Jan 2016 23:33:44 -0500 Received: by mail-yk0-f172.google.com with SMTP id y137so17864717yka.2 for ; Wed, 27 Jan 2016 20:33:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:content-type; bh=O7KV3XK4dDRhnz1rs9QUhzOT39U+dX77kJvI2YWWMz0=; b=ktomT1eNx92nKjJwHtbyxXD7O4DGBheodKsZ10zRtoVPpXZMN6umD03UdPB2SdABp0 NKwP5LgzcUCub02YA/N+EY/U48yQ80tl5ckigKmuyYJ08v883/aKXOsXv08t13tNGtJ0 rfcJU7Ff9XcNbFvf5nkuoyiVRie9HBvdGB5VedQ/NKM/aeetT6iTuM6ty7lDQsZCxA1W DdiUdB9IZq78IhH4c10Be5G97t7GDGUlT3IU/CqgnlflVW+4TGVwIfvRfv63r/26eVzU MWVOK1WYeE8I5VfNt/n1+hRzDi9snvHinth08xr8pn/enX11LaMpAXrIUdZV2iJpNCVW H6iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:content-type; bh=O7KV3XK4dDRhnz1rs9QUhzOT39U+dX77kJvI2YWWMz0=; b=b10nE9HZhV0MI8PzEwfFqCU7vUwhsmLQxucJlN7UFEOTIYWeBZuHbo9/qNP/yOTzHC GYZ7gj5fJ86xfFSia52cYrsJ55ToYZ5PgbAleU/BBTC/EySideRP4rOd4k6koIekQprM nQFhWfghvpUN/ma2AJ83AaRynQRBoY7x+SmAOK9UuB/Jnu2VwhVUS6X9bhq0uPihGLC9 ginMfy08LNbu9ZMGh49TFDbamxSCJehcn5G/zZY5pzw78YQ16KjrPIRoNcVPgK6Z8+wP Ypnx/cLRbcFWNcorXqte1wZsnH7pxLRyVaZQCkF9J2T8oIKhqI0sStLFmtfaJYSUKhL6 CYbQ== X-Gm-Message-State: AG10YOQ8K6ukyJbaQaA3PYTdeAxAQL44N1mONAAyad0ueNwSjGpoAmdrsaQrBg8qmr6TtsbnGlVpRaQ4IgLQ7g== X-Received: by 10.129.133.2 with SMTP id v2mr457959ywf.240.1453955621752; Wed, 27 Jan 2016 20:33:41 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.129.88.139 with HTTP; Wed, 27 Jan 2016 20:33:02 -0800 (PST) In-Reply-To: References: Date: Thu, 28 Jan 2016 13:33:02 +0900 X-Google-Sender-Auth: VL6e_xFXbUsA8pm_OYcMjym3qIk Message-ID: To: Anatol Belski , "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: PR1739 From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Anatol, On Thu, Jan 28, 2016 at 12:48 PM, Yasuo Ohgaki wrote: > > https://github.com/php/php-src/pull/1739 > This PR is good one. It opens handler first, then proceeds. > It fixes save handler crash also. > > The PR does not break our tests and PHP7 only fix. However, It changes > handler execution order. This change will not affect normal > operation/code at all, but user's unit tests may detect the difference > as we had already. > > Would you like to include this PR in released version? > My opinion is +1 for applying this. It's committed to master 46d4a371054f43fe8aeca14b83ba722adc84ac10 If you decide merge it, please cherry pick. Thank you. -- Yasuo Ohgaki yohgaki@ohgaki.net