Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:90986 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 97314 invoked from network); 28 Jan 2016 03:48:50 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 28 Jan 2016 03:48:50 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.174 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.160.174 mail-yk0-f174.google.com Received: from [209.85.160.174] ([209.85.160.174:32786] helo=mail-yk0-f174.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 73/A0-19998-1AF89A65 for ; Wed, 27 Jan 2016 22:48:49 -0500 Received: by mail-yk0-f174.google.com with SMTP id k129so17266196yke.0 for ; Wed, 27 Jan 2016 19:48:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=DeBszrUZT61LpV2krxN8lR6w/4z6LDmiTxiar7Bx9PQ=; b=0J95Fg5Aq4rGmplSEYbN94NeRvOi3FNA64fW0KCCXGvcIl1hRNSmJA4AxnvUBEPyOX pkWoiKoyg5QzQQtqSAqVBeacw4qHKlwKR0giFefuC8RDUBB/mcO/nHmP31VY/Nt+qS/v APWlC+iFWBBa+XRaP7vYNdIIhNazPEY4s7OjS9gYObbyXqLsH5itBRhe0k/lMUoCbWhr 0KSMuF+RDOwSJK2sTcVvvuu/Y/f597K3ySUPEGEyCdbxjRoh1MddBrAgZOmONNQ9+sDU FLA3KBwtUA44179ea9G34U2pBbxBn8WoxnKvad2EAq/8QgkDkXRQeO37VWKKQohoGUSW KdZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to:content-type; bh=DeBszrUZT61LpV2krxN8lR6w/4z6LDmiTxiar7Bx9PQ=; b=MT7RQOs6jBWgUFoRzQNqwYDMZOGK+EObelYQH+BLbQcpnJ2mD1kSVomDB+aRG13Lvw 8NQBcYBPAvzZkyO6dp9R8xc+ap+PPIVeEpDchYVWYY9LkDbrMSWeSf0KeMUdVDADPMiD mIzTodopunzdr0KP69Nwg1VP8uf414kIVg7G7+O/qv4Jy65S+8/gKjmH/fsQ6ijy8icL UO43aPwmFgc8N/FHP6fHZa1Y+D2pVj5xQLXbRi1rUWqCUR7vGxWl316MfdbihBcnkiD5 x8yQzyb+0CMRr+ijvF39awEtp7k+a5jfjwCJVwBBcM7O3sC+4uiuJU//Vh0BnoLuZmvv EDUA== X-Gm-Message-State: AG10YOT8s8HoaMIMJH4/BFh2FVS0xDEimhAP38Bx2G6FEYm5/UbjfxFiLnWx6hM4LROXfBMNxUPY0JxYXSYZcQ== X-Received: by 10.129.60.12 with SMTP id j12mr460272ywa.86.1453952926768; Wed, 27 Jan 2016 19:48:46 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.129.88.139 with HTTP; Wed, 27 Jan 2016 19:48:07 -0800 (PST) Date: Thu, 28 Jan 2016 12:48:07 +0900 X-Google-Sender-Auth: dBHSRDtj6oJxyoIsTnrncuqiTag Message-ID: To: Anatol Belski , "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: PR1739 From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Anatol, https://github.com/php/php-src/pull/1739 This PR is good one. It opens handler first, then proceeds. It fixes save handler crash also. The PR does not break our tests and PHP7 only fix. However, It changes handler execution order. This change will not affect normal operation/code at all, but user's unit tests may detect the difference as we had already. Would you like to include this PR in released version? My opinion is +1 for applying this. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net