Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90980
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.48 as permitted sender)
MIME-Version: 1.0
Sender: julienpauli@gmail.com
In-Reply-To: <CAGa2bXYzEdnxP098pJSNh_qGUFZpTYfS3XFrdJDV27YiYqKctQ@mail.gmail.com>
References: <CAGa2bXYzEdnxP098pJSNh_qGUFZpTYfS3XFrdJDV27YiYqKctQ@mail.gmail.com>
Date: Wed, 27 Jan 2016 15:01:16 +0100
Message-ID: <CAMUwpuTWCFzrJhndneTozgmGGo5gaGd9oYEmz1UVv2SKJ0eFcA@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Bug #67383 exec() leaks file and socket descriptors to
 called program
From: jpauli@php.net (Julien Pauli)

On Wed, Jan 27, 2016 at 1:03 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
> Hi all,
>
> This bug comes to my attention.
> https://bugs.php.net/bug.php?id=67383
>
> This report includes patch that prevents file descriptor leaks.
> https://bugs.php.net/patch-display.php?bug_id=67383&patch=SOCK_CLOEXEC-and-FD_CLOEXEC&revision=latest
>
> There may be cases that CLOEXEC cannot be applied blindly, but it
> seems this fixes lots of bugs including very old bugs.
> Why this patch is not merged and closed?
>
> Regards,
>
> --
> Yasuo Ohgaki
> yohgaki@ohgaki.net
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

Hi,

Great catch.

We already have many CLOEXEC, but we seem to be missing lots of them.

There is a note however, in bug ticket 67383, about a problem in FPM
with CLOEXEC, which should be qualified and addressed.
Just don't apply blindly the patch.


Julien.Pauli