Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90975
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.177 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <01d001d158e5$157f14a0$407d3de0$@belski.net>
References: <03a501d15439$fcbf9ca0$f63ed5e0$@php.net> <56A1054A.5080102@fedoraproject.org>
 <CAGa2bXaKaoiSKLpodHAEKurSEwrs9rYO25uwqGdbwg_KKUkGbg@mail.gmail.com>
 <56A2069B.2050007@fedoraproject.org> <56A21D68.6030403@fedoraproject.org>
 <56A825A9.9020706@gmail.com> <CAGa2bXYf9JFtH_yqjYfL7UiqDCzxmeFy9s-Ja4YPF+UjxDs3=w@mail.gmail.com>
 <56A85967.4090603@gmail.com> <CAGa2bXb_3eM2EaM=Zt2Mf-pLnGDvgek2M87O_7mL5f6HLp3s2w@mail.gmail.com>
 <01c101d158d9$a0533450$e0f99cf0$@belski.net> <CAGa2bXaEtd_j9yZG8H_Eyc7LX=Z1k_kV6P2C-vsNRt_9=Mv2mA@mail.gmail.com>
 <01d001d158e5$157f14a0$407d3de0$@belski.net>
Date: Wed, 27 Jan 2016 19:04:52 +0900
Message-ID: <CAGa2bXa8F893KyY42ZXn23dTakZK0Og5qsMnpVkXv48i4JxqMw@mail.gmail.com>
To: Anatol Belski <anatol.php@belski.net>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, Remi Collet <remi@fedoraproject.org>, 
	"internals@lists.php.net" <internals@lists.php.net>, Yasuo Ohgaki <yohgaki@php.net>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi Anatol,

On Wed, Jan 27, 2016 at 6:28 PM, Anatol Belski <anatol.php@belski.net> wrot=
e:
> If you're willing to work on fixing BC breaches till next minor RC, it mi=
ght be the way to proceed. If on the next RC we see no signs of regression,=
 so we could take it into the next minor. Otherwise, if we see that there a=
re still doubts on stability, we could stop trying to bring those changes i=
n a stable branch but go for master. Yasuo, it's really up to your willingn=
ess to spend time on stabilizing, maybe also checking the Horde tests where=
 the issues was initially discovered, and being aware of possible risk that=
 it possibly wouldn't make it into stable. Anyways for the upcoming final, =
releasing your patches seems risky.

I'm sure unit test failures cannot be fixed. It's relying on old buggy
behaviors. Since I cannot fix users' unit tests, I fully agree to
revert offending patches. In return, we'll have buggy behaviors, but
it shouldn't be fatal because users have been living with them for a
long time.

Unlike other internal functions, session module functions expose many
internal data and logic to user space. Even if changes should not
affect normal operations, changes may break users' tests as they are
testing abnormal cases usually. For this reason, I'll not commit
changes to released versions from now on, if it changes exposed
data/logic. e.g. Save handler execution order, session data
manipulation logic.

Please let me know if I should revert them. If it is not burden for
you, please revert them by yourself.

Thank you.

--
Yasuo Ohgaki
yohgaki@ohgaki.net