Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90971
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.170 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <56A8694D.8020906@gmail.com>
References: <03a501d15439$fcbf9ca0$f63ed5e0$@php.net> <56A1054A.5080102@fedoraproject.org>
 <CAGa2bXaKaoiSKLpodHAEKurSEwrs9rYO25uwqGdbwg_KKUkGbg@mail.gmail.com>
 <56A2069B.2050007@fedoraproject.org> <56A21D68.6030403@fedoraproject.org>
 <56A825A9.9020706@gmail.com> <CAGa2bXYf9JFtH_yqjYfL7UiqDCzxmeFy9s-Ja4YPF+UjxDs3=w@mail.gmail.com>
 <56A85967.4090603@gmail.com> <56A86476.5090401@fedoraproject.org> <56A8694D.8020906@gmail.com>
Date: Wed, 27 Jan 2016 17:09:01 +0900
Message-ID: <CAGa2bXa+ZLaTPtuf4m1xttYofaf6KUvuT5Ack1Qw4=-fQ6=_JA@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: Remi Collet <remi@fedoraproject.org>, 
	"internals@lists.php.net" <internals@lists.php.net>, Yasuo Ohgaki <yohgaki@php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi all and Stas,

On Wed, Jan 27, 2016 at 3:53 PM, Stanislav Malyshev <smalyshev@gmail.com> wrote:
>> The Horde_SessionHandler test suite still fail differently: Both
>> are related to "getSessionIDs" (which list active sessions)
>
> Any way to get a short repro script for that too?
>
> In general, I start to be more and more doubtful about the idea of
> messing with sessions in stable versions.

Don't rush into conclusion.
It was yet another session inspection test code is finding behavior change

https://gist.github.com/yohgaki/c3783b22bae9dcb78d69

This and php_session_cache_limiter() change result in successful tests.

This change is to avoid expired session being active again. (Which is
really bad behavior, but it's probability based so it does not matter
much for current PHP, though)

If these bug fixes that correct invalid/wrong session behavior are not
suitable stable releases, I don't mind at all committing them to
master only. It saves my time a lot :)

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net