Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90968
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.171 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <56A86476.5090401@fedoraproject.org>
References: <03a501d15439$fcbf9ca0$f63ed5e0$@php.net> <56A1054A.5080102@fedoraproject.org>
 <CAGa2bXaKaoiSKLpodHAEKurSEwrs9rYO25uwqGdbwg_KKUkGbg@mail.gmail.com>
 <56A2069B.2050007@fedoraproject.org> <56A21D68.6030403@fedoraproject.org>
 <56A825A9.9020706@gmail.com> <CAGa2bXYf9JFtH_yqjYfL7UiqDCzxmeFy9s-Ja4YPF+UjxDs3=w@mail.gmail.com>
 <56A85967.4090603@gmail.com> <56A86476.5090401@fedoraproject.org>
Date: Wed, 27 Jan 2016 15:46:54 +0900
Message-ID: <CAGa2bXb5CHc=-S0KO0_10nUR_K-7-zx-cyvtawDtT_fqfdXfzA@mail.gmail.com>
To: Remi Collet <remi@fedoraproject.org>
Cc: Stanislav Malyshev <smalyshev@gmail.com>, 
	"internals@lists.php.net" <internals@lists.php.net>, Yasuo Ohgaki <yohgaki@php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi Remi,

On Wed, Jan 27, 2016 at 3:32 PM, Remi Collet <remi@fedoraproject.org> wrote:
>
> There were 2 failures:
>
> 1) Horde_SessionHandler_Storage_BuiltinTest::testGc
> Failed asserting that two arrays are equal.
> - --- Expected
> +++ Actual
> @@ @@
>  Array (
> +    0 => 'db620868d98d974c1193d14c3ad7bb35'
>  )

This sounds like php_session_gc() location correction patch is the cause.

https://gist.github.com/yohgaki/c3783b22bae9dcb78d69

This patch allows expired session being active again, but this may work.

>
> /usr/share/tests/pear/Horde_SessionHandler/Horde/SessionHandler/Storage/
> BuiltinTest.php:98
>
> 2) Horde_SessionHandler_Storage_Sql_Pdo_SqliteTest::testList
> Failed asserting that two arrays are equal.
> - --- Expected
> +++ Actual
> @@ @@
>  Array (
> - -    0 => 'sessionid'
> - -    1 => 'sessionid2'
>  )

I have no idea for this now.

>
> /usr/share/tests/pear/Horde_SessionHandler/Horde/SessionHandler/Storage/
> Base.php:43
> /usr/share/tests/pear/Horde_SessionHandler/Horde/SessionHandler/Storage/
> Sql/Base.php:50

Will fedora23's "dnf install php-horde*" install horde tests also?

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net