Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90962
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.182 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <56A825A9.9020706@gmail.com>
References: <03a501d15439$fcbf9ca0$f63ed5e0$@php.net> <56A1054A.5080102@fedoraproject.org>
 <CAGa2bXaKaoiSKLpodHAEKurSEwrs9rYO25uwqGdbwg_KKUkGbg@mail.gmail.com>
 <56A2069B.2050007@fedoraproject.org> <56A21D68.6030403@fedoraproject.org> <56A825A9.9020706@gmail.com>
Date: Wed, 27 Jan 2016 12:19:12 +0900
Message-ID: <CAGa2bXYf9JFtH_yqjYfL7UiqDCzxmeFy9s-Ja4YPF+UjxDs3=w@mail.gmail.com>
To: Stanislav Malyshev <smalyshev@gmail.com>
Cc: Remi Collet <remi@fedoraproject.org>, 
	"internals@lists.php.net" <internals@lists.php.net>, Yasuo Ohgaki <yohgaki@php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi all,

On Wed, Jan 27, 2016 at 11:04 AM, Stanislav Malyshev
<smalyshev@gmail.com> wrote:
>
>>> It seems that using a user land SessionHandler, the "write" method
>>> is not called, raising this issue.
>>
>> Attached as .phpt
>
> Bisecting with this test shows a15e9ccba8a34553c029fb4574edba87c76447e5
> as the breaking change. So we need to either fix it (this week, as next
> week it should be released) or revert this patch.

Note for this issue.
The change does not breaks normal codes as PHP cannot set new session
ID when header is already sent. The session is _not_ accessible
anyway. Not writing orphaned session does not matter at all.

If you understand exactly what is happening, it is understandable this
is not a BC for production code, but only breaks test code that
inspect session behaviors and it found out bogus write() is gone now.

Anyway, to fix existing app/framework unit test failures, (it's not
fixing anything but leave bogus write(), though)
removing php_session_abort() from php_session_cache_limitter() should be enough.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net