Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90899
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.177 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <CAGa2bXYe_YAvhb8B7wYKmbs-UiFyubCGyMpOS5TkPURk6i1c1g@mail.gmail.com>
References: <03a501d15439$fcbf9ca0$f63ed5e0$@php.net> <56A1054A.5080102@fedoraproject.org>
 <CAGa2bXaKaoiSKLpodHAEKurSEwrs9rYO25uwqGdbwg_KKUkGbg@mail.gmail.com>
 <56A2069B.2050007@fedoraproject.org> <CAGa2bXYe_YAvhb8B7wYKmbs-UiFyubCGyMpOS5TkPURk6i1c1g@mail.gmail.com>
Date: Mon, 25 Jan 2016 13:06:41 +0900
Message-ID: <CAGa2bXZs1YqV3U1LB6X0piMSM4cnYtSTpRj52ejoi6tWiB1TsA@mail.gmail.com>
To: Remi Collet <remi@fedoraproject.org>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] PHP 7.0.3 RC1 is available for testing - **** BC break ***
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi Remi,

On Mon, Jan 25, 2016 at 11:47 AM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:
>
> On Fri, Jan 22, 2016 at 7:38 PM, Remi Collet <remi@fedoraproject.org> wrote:
>>
>> It seems that using a user land SessionHandler, the "write" method is
>> not called, raising this issue.
>
> Thank you. I'll check it soon. (in a few days)

Thank you for the script.

I've tried and checked the output, but it seems OK to me.
It call open->read->write->close, twice.

--------------------------------------------------------
// Write
session_name('sessionname');
session_id('sessionid');

session_start(); // This should call open/read

$_SESSION['sessiondata'] = 'foo';
session_write_close(); // This should call write/close

echo '------------------'.PHP_EOL;
// Reopen
session_write_close();
// Copy & paste error? Does not need this line and should not
// call handlers while session is not active. Otherwise,
// something wrong could happen.

session_name('sessionname');
session_id('sessionid');
session_start(); // This should call open/read
var_dump($_SESSION);
// Shutdown should call write/close
--------------------------------------------------------

As I add comments in code, session_write_close() should not do
anything but the test script assumes write/close is called?
I've tested with Fedora 23's PHP 5.6.17 and got the expected result

--------------------------------------------------------
"MySessionHandler::__construct"
string(22) "MySessionHandler::open"
string(4) "/tmp"
string(11) "sessionname"
string(22) "MySessionHandler::read"
string(9) "sessionid"
string(23) "MySessionHandler::write"
string(9) "sessionid"
string(22) "sessiondata|s:3:"foo";"
string(23) "MySessionHandler::close"
------------------
string(22) "MySessionHandler::open"
string(4) "/tmp"
string(11) "sessionname"
string(22) "MySessionHandler::read"
string(9) "sessionid"
array(1) {
  ["sessiondata"]=>
  string(3) "foo"
}
string(23) "MySessionHandler::write"
string(9) "sessionid"
string(22) "sessiondata|s:3:"foo";"
string(23) "MySessionHandler::close"
--------------------------------------------------------

Could you give more details or other test script?

Thank you!

--
Yasuo Ohgaki
yohgaki@ohgaki.net