Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90751
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZG4zKQ9gYsqn326LmTnK=7eY+f6SW35OwA9nRXV-n_pQ@mail.gmail.com>
References: <CAGa2bXZG4zKQ9gYsqn326LmTnK=7eY+f6SW35OwA9nRXV-n_pQ@mail.gmail.com>
Date: Wed, 20 Jan 2016 23:28:42 +0100
Message-ID: <CAF+90c-wsdSb11duy1Weka3z4w-bFFN7h3kjSC7Pt8gh9K=i0Q@mail.gmail.com>
To: Yasuo Ohgaki <yohgaki@ohgaki.net>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a11c0219e28831f0529cb822c
Subject: Re: [PHP-DEV] WIKI: phpng-upgrading
From: nikita.ppv@gmail.com (Nikita Popov)

--001a11c0219e28831f0529cb822c
Content-Type: text/plain; charset=UTF-8

On Wed, Jan 20, 2016 at 10:55 PM, Yasuo Ohgaki <yohgaki@ohgaki.net> wrote:

> Hi ZendEngine developers,
>
> I'm not sure if the wiki page is maintained, but I noticed few errors.
>
> https://wiki.php.net/phpng-upgrading#strings
> has following example.
>
> - ZVAL_STRING(zv, str, 1);
> + ZVAL_STRING(zv, str);
>
> - ZVAL_STRINGL(zv, str, len, 1);
> + ZVAL_STRINGL(zv, str, len);
>
> - ZVAL_STRING(zv, str, 0);
> + ZVAL_STRING(zv, str);
> + efree(str);
>
> - ZVAL_STRINGL(zv, str, len, 0);
> + ZVAL_STRINGL(zv, str, len);
> + efree(str);
>
> Since PHP5 has following definition for ZVAL_STRING*()
>
> #define ZVAL_STRING(z, s, duplicate) do {    \
>         const char *__s=(s);                \
>         zval *__z = (z);                    \
>         Z_STRLEN_P(__z) = strlen(__s);        \
>         Z_STRVAL_P(__z) = (duplicate?estrndup(__s,
> Z_STRLEN_P(__z)):(char*)__s);\
>         Z_TYPE_P(__z) = IS_STRING;            \
>     } while (0)
>
> the example's 0 and 1 are flipped, efree() locations are wrong.
>

These examples are correct. In PHP 7 ZVAL_STRING always duplicates, which
is what the 1 parameter used to signify.


> In https://wiki.php.net/phpng-upgrading#zend_string_api ,
> it says
>
> zend_string_init(char *val, int len, int persistent)
>
> Current definition is
>
> zend_string_init(char *val, size_t len, int persistent)
>
> Should I update the doc or is the doc is maintained
> elsewhere?
>

I've fixed this. But yes, you should update the doc, it's not maintained
elsewhere.

Thanks,
Nikita

--001a11c0219e28831f0529cb822c--