Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90750
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.180 as permitted sender)
MIME-Version: 1.0
Sender: yohgaki@gmail.com
In-Reply-To: <20160120220703.GA16606@SeanLaptop.prodvpn.etsy.com>
References: <CAGa2bXZG4zKQ9gYsqn326LmTnK=7eY+f6SW35OwA9nRXV-n_pQ@mail.gmail.com>
 <20160120220703.GA16606@SeanLaptop.prodvpn.etsy.com>
Date: Thu, 21 Jan 2016 07:19:29 +0900
Message-ID: <CAGa2bXbkaYiHyLw-0CPPV=D1X-tZwJR0hsjuQtG-4ZSjGY61Tg@mail.gmail.com>
To: Sean DuBois <sean@siobud.com>
Cc: "internals@lists.php.net" <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] WIKI: phpng-upgrading
From: yohgaki@ohgaki.net (Yasuo Ohgaki)

Hi Sean,

On Thu, Jan 21, 2016 at 7:07 AM, Sean DuBois <sean@siobud.com> wrote:
>
> I tried to get access to that page as well, but didn't have any luck
> would you mind adding the zend_parse_paramaters changes?
>
> 'l' went from 'long' -> 'zend_long' and 's' went from 'int' -> 'size_t'.
>
> So many extensions have been ported without this in mind, and it bites
> in really nasty hard to reproduce runtime ways.

Good point.
zend_parse_parameters() is using "size_t" for string length, since
zend_string uses size_t for it.

struct _zend_string {
    zend_refcounted_h gc;
    zend_ulong        h;                /* hash value */
    size_t            len;
    char              val[1];
};

AFAIK, PHP7 repo's function parameters are changed to size_t.
This should be described in upgrading doc for 3rd party module
developers.

Regards,

--
Yasuo Ohgaki
yohgaki@ohgaki.net