Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:90745 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 28486 invoked from network); 20 Jan 2016 21:56:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 20 Jan 2016 21:56:25 -0000 Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.177 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.160.177 mail-yk0-f177.google.com Received: from [209.85.160.177] ([209.85.160.177:33796] helo=mail-yk0-f177.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id E9/56-22511-88200A65 for ; Wed, 20 Jan 2016 16:56:24 -0500 Received: by mail-yk0-f177.google.com with SMTP id a85so26711056ykb.1 for ; Wed, 20 Jan 2016 13:56:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to:content-type; bh=PBw+vEcskgE/PNdlIc7/BLxBrd/BrG5a3kLdhhIJ3zE=; b=pB9ljvDwreZnyh3o+18tNAUtqj80yAVM0wsWfSJSRXo1YMpUobHFWm9o4Lmgg7xqCN GihXHGWUyf6sVCwQgCPbp6Jy3vsr/VoDiTcYACLctEAYkNVrwIaJm8lGwH6Ujycf/2aC aZauGYa3yOto+LgEaLwll/S9Oslz8Mducji3UxGvMnB2E9G1cEwDWSka3rU/VOOyDeHA qkKGfII9kD/vk+WIiOXS7EpZMYvw/gzkPFlMfeiWG/OgGOEQ6jt6AIFZlWIAgA9xb9nV Du30rZWBqPDYBsbJEP7DRWNp1qn0wAjs3t35t4VZDOtHKZNgXcH6NzBj9CMTARGVvk59 8AhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to:content-type; bh=PBw+vEcskgE/PNdlIc7/BLxBrd/BrG5a3kLdhhIJ3zE=; b=SXfCW7OwuI0cV2fb2WAyyF95J/W4VIIENnT9FAzRBwslDxLREZ+fPc3hdiR6mp4rD7 TUYUgqZgVi7cSBFXuHtxaIeYfI4TkM4JZt77o15S3V+RitLRdivH4LHgs7SowVaBk/80 cRQGDw9CPgmOIa8UGZxOM54NebiHXBTfzGkkR+XaxkSx4AJ4bE3VFQB1canWho3S9DoB eOK6vg/KFrT6j0gvJ9EVY3cOc66JlfpTDnJ6ZJxcDp4gi3n2AeZV4VJ0Yi9DRA/f1nxl +gg5tYPBCPXILn6rolu7YhIfAPO2ZdiJfMJiEjDDCe653PHHezFQGEAeARiYPTINjjyj DoCg== X-Gm-Message-State: ALoCoQk8rNdNC/zbqf8sz55Gam8Oz8IexZ7i0+9F1Hka7mbpg8fE7f6LzAsB01DdsScz40KpA+ZmnPQp8ef+dXHKHk800YIvlw== X-Received: by 10.129.60.12 with SMTP id j12mr24381537ywa.86.1453326981174; Wed, 20 Jan 2016 13:56:21 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.129.88.139 with HTTP; Wed, 20 Jan 2016 13:55:41 -0800 (PST) Date: Thu, 21 Jan 2016 06:55:41 +0900 X-Google-Sender-Auth: pIzOQ90s8I4tV5SdeSCkH6ZrxGg Message-ID: To: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: WIKI: phpng-upgrading From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi ZendEngine developers, I'm not sure if the wiki page is maintained, but I noticed few errors. https://wiki.php.net/phpng-upgrading#strings has following example. - ZVAL_STRING(zv, str, 1); + ZVAL_STRING(zv, str); - ZVAL_STRINGL(zv, str, len, 1); + ZVAL_STRINGL(zv, str, len); - ZVAL_STRING(zv, str, 0); + ZVAL_STRING(zv, str); + efree(str); - ZVAL_STRINGL(zv, str, len, 0); + ZVAL_STRINGL(zv, str, len); + efree(str); Since PHP5 has following definition for ZVAL_STRING*() #define ZVAL_STRING(z, s, duplicate) do { \ const char *__s=(s); \ zval *__z = (z); \ Z_STRLEN_P(__z) = strlen(__s); \ Z_STRVAL_P(__z) = (duplicate?estrndup(__s, Z_STRLEN_P(__z)):(char*)__s);\ Z_TYPE_P(__z) = IS_STRING; \ } while (0) the example's 0 and 1 are flipped, efree() locations are wrong. In https://wiki.php.net/phpng-upgrading#zend_string_api , it says zend_string_init(char *val, int len, int persistent) Current definition is zend_string_init(char *val, size_t len, int persistent) Should I update the doc or is the doc is maintained elsewhere? Regards -- Yasuo Ohgaki yohgaki@ohgaki.net