Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90680
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.215.54 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <CAESVnVr=RjyJX272rgZT-3gJpmxwLkkHYAuUCLxb4wWtLFG-bw@mail.gmail.com>
References: <CAESVnVoJBRF3VfKrnWGNCah3KAbxwjacPAwR1HZUC-T-vN=KDQ@mail.gmail.com>
	<77.F6.12097.81D2C865@pb1.pair.com>
	<B0800012-C341-468D-AE1C-BF6551AB356F@rouvenwessling.de>
	<CAESVnVobg-woJ2eHff_RSFkkMPZLyqOia1U+agSSTNxCjYc_tg@mail.gmail.com>
	<3F.20.05337.CEE68965@pb1.pair.com>
	<CAESVnVr=RjyJX272rgZT-3gJpmxwLkkHYAuUCLxb4wWtLFG-bw@mail.gmail.com>
Date: Sun, 17 Jan 2016 12:34:27 +0100
Message-ID: <CABM2syuZ8LbBBs_Nnp5CvA_BuqSc53Rvq3gL4bxxOJ5by6QNbQ@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: internals@lists.php.net, Andrea Faulds <ajf@ajf.me>
Content-Type: multipart/alternative; boundary=001a113ff650d75fb205298604a7
Subject: Re: [PHP-DEV] Re: [RFC] Normalize token_get_all() output (with flag)
From: stig.bakken@gmail.com (Stig Bakken)

--001a113ff650d75fb205298604a7
Content-Type: text/plain; charset=UTF-8

On Jan 17, 2016 05:23, "Sara Golemon" <pollita@php.net> wrote:
>
> Okay, i've got a starting point up at
> https://github.com/phplang/php-token .  It's basically just
> token_get_all() and token_name() as they currently stand (I didn't
> even bother overriding the behavior in token_name() yet).  I did
> change some of the codeflow layout a bit (and add support for scanning
> files in the process), but that's it.

I really like this, funny really that it took until now for someone to get
enough of the old interface :)

But rather than overloading the existing token_get_all() function with
flags that change its behavior, what about just adding a new function, say
token_get_all_assoc(), and give it a TOKEN_LINENUMS flag if you want to
make line numbers optional for performance?

At least in my experience, code becomes more readable with new
method/function names than with a bunch of optional flags in cases like
this.

- Stig

--001a113ff650d75fb205298604a7--