Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:90655 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 21452 invoked from network); 15 Jan 2016 07:59:25 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Jan 2016 07:59:25 -0000 Authentication-Results: pb1.pair.com header.from=yohgaki@gmail.com; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=yohgaki@gmail.com; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.160.169 as permitted sender) X-PHP-List-Original-Sender: yohgaki@gmail.com X-Host-Fingerprint: 209.85.160.169 mail-yk0-f169.google.com Received: from [209.85.160.169] ([209.85.160.169:36195] helo=mail-yk0-f169.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 76/21-10048-BD6A8965 for ; Fri, 15 Jan 2016 02:59:23 -0500 Received: by mail-yk0-f169.google.com with SMTP id v14so441382370ykd.3 for ; Thu, 14 Jan 2016 23:59:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=sLPFv8AcvrpMb3YWk7P2lkLjJTm6/Iu360cNIvOBvYM=; b=XCiFFWAmC+o6NiRYPsN3Ag2MdZVph2U+Bqig9Ok7QW9uqt7SQ3nQX/9VU98XA3oFWg ldJ+huB4wQWouZaNHrWEIao96YlwO+TIeGRQvAsfzTUvWTY9CplldmAhvKEg/Z+Cgaug JHaHWP1X+rDG9VhMI0dENU7vm65jVyWF1tS5nVrJbPYi4j6SYQhhDhlaxXamtNR8j5TE uWoYqFX6IdNakprBhMpaSv4MJy/XJ/EkQhQsBE9MmLudoLYOYqyBMqExEbcVnkKcXEHG 6bmKfI8eOlXJEe2Odeztm1d55gMnNVfAY8+xIXyTbGsk/zkgNouDZ8Vv8T5ULn5ukpeB bXSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=sLPFv8AcvrpMb3YWk7P2lkLjJTm6/Iu360cNIvOBvYM=; b=akTrQG/i9yAN2X03XfQ83dL4P9+64G4o4koRdkxxl88IyCkDAe4RAeD+Z/b2w/kzFU s8eSJKIB59cHVTas4o8FJHBz2ZOtfAD2RVJ9pN/bq6xRxzbp+1/vr4F/f+fx5sQhPcc4 aRnwrhMoG5AWkyCRpfRzZkOkkj/CVW+yxKHW/QBFxQgNx7KpgOOxwE/E8ueOo3Vbtq1n mD61QAVvRggb6V65sZ1/Idxm0XBUcWCfSFeQe2DoHkaqeNcrtZ9bmeNzq/ck5OCeXy/H j4kWrsO/usPBEaEz2EFl5Z480/VwdTboDlB19+f9uTVYUyDJ5NSPcvVJKCl1+ocwpHyk 0Wsw== X-Gm-Message-State: ALoCoQlXcoinMsOgAU2DtfXQuntuh62/OprmRUZVesKNpjIIkci84/f5vWp0fSvBbnbz5+6U9fRlickqiENU2G/ZZbzCTjz2pg== X-Received: by 10.13.216.71 with SMTP id a68mr6573050ywe.0.1452844756552; Thu, 14 Jan 2016 23:59:16 -0800 (PST) MIME-Version: 1.0 Sender: yohgaki@gmail.com Received: by 10.129.88.139 with HTTP; Thu, 14 Jan 2016 23:58:37 -0800 (PST) In-Reply-To: <56989A57.9030401@gmail.com> References: <56989A57.9030401@gmail.com> Date: Fri, 15 Jan 2016 16:58:37 +0900 X-Google-Sender-Auth: xcZYSF_S7-Cd81YZCoOP-MOxkmA Message-ID: To: Stanislav Malyshev Cc: "internals@lists.php.net" Content-Type: text/plain; charset=UTF-8 Subject: Re: [PHP-DEV] Fixing bug #71038 session_start() returns TRUE on failure From: yohgaki@ohgaki.net (Yasuo Ohgaki) Hi Stas, On Fri, Jan 15, 2016 at 4:05 PM, Stanislav Malyshev wrote: >> I made PR >> https://github.com/php/php-src/pull/1721 >> >> for bug #71038 >> https://bugs.php.net/bug.php?id=71038 >> >> Currently, the patch is written as it should and >> breaks compatibility on PHP 5.6. >> >> To be compatible with PHP 5.6 (PHP 7.0 is OK), >> it may ignore read failures returned from save handlers. > > I think it should return false on 5.6 too. The docs say: > > This function returns TRUE if a session was successfully started, > otherwise FALSE. > > Thus, if the session was *not* successfully started, it should return > false. In most cases other than read failure, PHP 5.6 is made return FALSE for failures also. Read failure is special because old save handler allowed returning false for read and continued as if there is no errors. I cannot fix this without braking buggy save handlers compatibility. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net