Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:90654 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 17016 invoked from network); 15 Jan 2016 07:06:09 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 15 Jan 2016 07:06:09 -0000 Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.41 as permitted sender) X-PHP-List-Original-Sender: smalyshev@gmail.com X-Host-Fingerprint: 209.85.220.41 mail-pa0-f41.google.com Received: from [209.85.220.41] ([209.85.220.41:36132] helo=mail-pa0-f41.google.com) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id 1B/60-10048-F5A98965 for ; Fri, 15 Jan 2016 02:06:07 -0500 Received: by mail-pa0-f41.google.com with SMTP id yy13so297656105pab.3 for ; Thu, 14 Jan 2016 23:06:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=WWut7dX1oXk9nQ3oCV9XTyGs9dHWBPs9/bMYUq56cqE=; b=HC0nEWjpGHO1thsFCySHNE/Ycbza9SvWXQWs53VatlXYERgTVTfHWOXka8x5A7nc38 rZKnyayb989ILfukesn+IweUuoTi/cWqOBJxLJGZfPcjGj/3KPdfmv+OgSQBFfRzs0Af yk6Q3FdzxEtCbJ/wzFzvnpzfqrkFUKMA6BYcIDlzarfQoabkdVrL937omVQxlTzLpHKv l7u2VabO6nbosacc2/jBhuGim+XBsLLqNFwiq5UEJCJlUBWOkp1s55xcai2J1RKaW65c qxxHCQYI6vklRwv7vwdQ1bftowkOMIiaI5NLQBZZgg/hvcwMUFdvoHAC9Dd11p4C+1Ge 7jvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=WWut7dX1oXk9nQ3oCV9XTyGs9dHWBPs9/bMYUq56cqE=; b=UdcpwbGjU2I6KLoyRU9oB69HdEJHn2GHF1sOQiJ6QBxmAtv5kIQ/1Ssfhkrsvr2ZXI ogw+6LJ26g51c3wMPBdaO2cy+NGLz599shKdAv1CL7W3cA9PvPwtywtLhzB6S7vp6/zy z3a9kZl2ml2M6FcGXqvg1Q2Dt/p7S/5HQND0KLEUeea3FHvXhjCb5JMPVlLdGrRNl+IU B0uyzhHekBTIc9kS+klch1zvWoKre+KHPNI6StlbffW09vEZ/7J51u66bZsNY5KpEsgZ yCqrUlOKbooffCSXYOqt/QJE2MofhifPC2TeVCx4ZFX8WHCe1mMXaVVnyAmC56NoXudm J9zA== X-Gm-Message-State: AG10YORqbmsB5iKVQA06i0YmwOvtkiJdwKYH1bHAu6f4ytK0p2qblgEed7jXiQifeyi6vg== X-Received: by 10.66.102.40 with SMTP id fl8mr2343628pab.136.1452841564116; Thu, 14 Jan 2016 23:06:04 -0800 (PST) Received: from ?IPv6:2602:304:cdc2:e5f0:1190:dc9e:4543:fdef? ([2602:304:cdc2:e5f0:1190:dc9e:4543:fdef]) by smtp.gmail.com with ESMTPSA id 17sm13425893pfq.51.2016.01.14.23.06.02 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 14 Jan 2016 23:06:03 -0800 (PST) To: Yasuo Ohgaki , "internals@lists.php.net" References: Message-ID: <56989A57.9030401@gmail.com> Date: Thu, 14 Jan 2016 23:05:59 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Fixing bug #71038 session_start() returns TRUE on failure From: smalyshev@gmail.com (Stanislav Malyshev) Hi! > I made PR > https://github.com/php/php-src/pull/1721 > > for bug #71038 > https://bugs.php.net/bug.php?id=71038 > > Currently, the patch is written as it should and > breaks compatibility on PHP 5.6. > > To be compatible with PHP 5.6 (PHP 7.0 is OK), > it may ignore read failures returned from save handlers. I think it should return false on 5.6 too. The docs say: This function returns TRUE if a session was successfully started, otherwise FALSE. Thus, if the session was *not* successfully started, it should return false. -- Stas Malyshev smalyshev@gmail.com