Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90601
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain hristov.com from 91.196.125.214 cause and error)
To: internals@lists.php.net
References: <62D88386-9A6B-42F6-821C-00279561D598@zort.net>
Message-ID: <5696553F.40902@hristov.com>
Date: Wed, 13 Jan 2016 14:46:39 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <62D88386-9A6B-42F6-821C-00279561D598@zort.net>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] PR #1723 - fix for crash in mysqli_connect
From: php@hristov.com (Andrey Hristov)

  Hi,
the patch looks ok. Sorry that I borked this.

Will push it in a short!

Thanks,
Andrey

On 13.01.2016 14:37, John Bafford wrote:
> Hi all,
>
> Can someone take a look at this PR to fix a crash with mysqli_connect arising with a mysqlnd refactor in e81ecc80c in master from November:
>
> https://github.com/php/php-src/pull/1723
>
> When attempting to mysqlI_connect(‘localhost’, ‘user’, ‘pass), the mysqlnd_conn_data::get_scheme introduced in e81ecc80c was no longer able to update the socket_or_pipe in mysqlnd_conn_data::connect  with the socket filename in the event hostname == localhost. This causes a crash in mysqlnd_conn_data::connect when an attempt is made to duplicate the string to store it in conn->unix_socket.s.
>
> Thanks!
>
> -John
>
>