Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:90600 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 12863 invoked from network); 13 Jan 2016 13:37:26 -0000 Received: from unknown (HELO lists.php.net) (127.0.0.1) by localhost with SMTP; 13 Jan 2016 13:37:26 -0000 Authentication-Results: pb1.pair.com header.from=jbafford@zort.net; sender-id=pass Authentication-Results: pb1.pair.com smtp.mail=jbafford@zort.net; spf=pass; sender-id=pass Received-SPF: pass (pb1.pair.com: domain zort.net designates 96.241.205.2 as permitted sender) X-PHP-List-Original-Sender: jbafford@zort.net X-Host-Fingerprint: 96.241.205.2 nova.zort.net Received: from [96.241.205.2] ([96.241.205.2:60171] helo=nova.zort.net) by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP id DF/50-10601-51356965 for ; Wed, 13 Jan 2016 08:37:26 -0500 Received: from [10.0.1.2] (pulsar.zort.net [96.241.205.6]) (authenticated bits=0) by nova.zort.net (8.14.5/8.14.5) with ESMTP id u0DDbM9t006399 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 13 Jan 2016 08:37:23 -0500 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <62D88386-9A6B-42F6-821C-00279561D598@zort.net> Date: Wed, 13 Jan 2016 08:37:21 -0500 To: PHP internals Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) X-Mailer: Apple Mail (2.2104) Subject: PR #1723 - fix for crash in mysqli_connect From: jbafford@zort.net (John Bafford) Hi all, Can someone take a look at this PR to fix a crash with mysqli_connect = arising with a mysqlnd refactor in e81ecc80c in master from November: https://github.com/php/php-src/pull/1723 When attempting to mysqlI_connect(=E2=80=98localhost=E2=80=99, = =E2=80=98user=E2=80=99, =E2=80=98pass), the = mysqlnd_conn_data::get_scheme introduced in e81ecc80c was no longer able = to update the socket_or_pipe in mysqlnd_conn_data::connect with the = socket filename in the event hostname =3D=3D localhost. This causes a = crash in mysqlnd_conn_data::connect when an attempt is made to duplicate = the string to store it in conn->unix_socket.s. Thanks! -John