Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90581
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.45 as permitted sender)
To: Sara Golemon <pollita@php.net>, =?UTF-8?Q?Rouven_We=c3=9fling?=
 <me@rouvenwessling.de>
References: <CAESVnVoJBRF3VfKrnWGNCah3KAbxwjacPAwR1HZUC-T-vN=KDQ@mail.gmail.com>
 <77.F6.12097.81D2C865@pb1.pair.com>
 <B0800012-C341-468D-AE1C-BF6551AB356F@rouvenwessling.de>
 <CAESVnVobg-woJ2eHff_RSFkkMPZLyqOia1U+agSSTNxCjYc_tg@mail.gmail.com>
Cc: Andrea Faulds <ajf@ajf.me>, PHP internals <internals@lists.php.net>
Message-ID: <56958BA2.1040504@gmail.com>
Date: Tue, 12 Jan 2016 15:26:26 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CAESVnVobg-woJ2eHff_RSFkkMPZLyqOia1U+agSSTNxCjYc_tg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [RFC] Normalize token_get_all() output (with flag)
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> Nice! I'll say one thing though: If we're going to introduce a class,
> I'm tempted to leave token_get_all alone (or at least limit its
> changes to what's in the current porposal), and have the PhpToken
> class implement its own static method to do the same thing.  This

I like this idea better. It is also conceptually simpler - you just have
one class to deal with.

> How does this sound?
> 1. Keep the current RFC basically as is.  It's a minor addition to
> token_get_all() which can be slotted into existing code to improve
> readability, but offers little advantage beyond that.
> 2. Make a new extension to prototype this PhpToken class outside of
> the php-src tree, add all the extra goodies we want (array of token
> return, iterator of token return, extra info, limited info, etc...)
> 3. When this extension is good and solid, propose merging into core.

Sounds great! I wonder if it'd be possible to make a real streaming
iterator? That would be so nice.

-- 
Stas Malyshev
smalyshev@gmail.com