Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90578
Return-Path: <smalyshev@gmail.com>
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 44972 invoked from network); 12 Jan 2016 23:03:26 -0000
Received: from unknown (HELO lists.php.net) (127.0.0.1)
  by localhost with SMTP; 12 Jan 2016 23:03:26 -0000
Authentication-Results: pb1.pair.com header.from=smalyshev@gmail.com; sender-id=pass
Authentication-Results: pb1.pair.com smtp.mail=smalyshev@gmail.com; spf=pass; sender-id=pass
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.220.48 as permitted sender)
X-PHP-List-Original-Sender: smalyshev@gmail.com
X-Host-Fingerprint: 209.85.220.48 mail-pa0-f48.google.com  
Received: from [209.85.220.48] ([209.85.220.48:36704] helo=mail-pa0-f48.google.com)
	by pb1.pair.com (ecelerity 2.1.1.9-wez r(12769M)) with ESMTP
	id 30/A8-27877-B3685965 for <internals@lists.php.net>; Tue, 12 Jan 2016 18:03:24 -0500
Received: by mail-pa0-f48.google.com with SMTP id yy13so254355775pab.3
        for <internals@lists.php.net>; Tue, 12 Jan 2016 15:03:23 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20120113;
        h=subject:to:references:from:message-id:date:user-agent:mime-version
         :in-reply-to:content-type:content-transfer-encoding;
        bh=+c1nAgnQMnvqDdYQtjOS7t9XrMfEVLPrPb7t8PlFDVA=;
        b=b+6JigXP9dnfeJGmKdR5F8I6ZD7OMfA1q6SOD+EAeBWp/Dvc6LgMaV+kTgcUyRW4DU
         QPkovNvykGkCi3mg/F30Q3GgInIvRT7nkoBXsQolM2CEp19ICNVHVhcXrwrlTAvf/D60
         feXEdg4gOHpm1QZP/7w08EzyRQISSiq+SxDv87nm+mQN918G2xkydjGAFQKxeXp83/Y+
         TLHS6J8JpasrHtugQhjbrRJ9th5MFOgYM46MPMh4ce+8xaq5hkiVeuhPNW0KNaMze2JQ
         SSFfVn6cssAhp9mlDv4ygjVA4pWla7QTExNZ4XgURnqg4RfgLwWG5Ovx1EDWQm3vfvEm
         N/2w==
X-Received: by 10.66.184.15 with SMTP id eq15mr136198343pac.42.1452639801043;
        Tue, 12 Jan 2016 15:03:21 -0800 (PST)
Received: from stas-air.corp.wikimedia.org (tan1.corp.wikimedia.org. [198.73.209.1])
        by smtp.gmail.com with ESMTPSA id q136sm32690895pfq.66.2016.01.12.15.03.20
        (version=TLSv1/SSLv3 cipher=OTHER);
        Tue, 12 Jan 2016 15:03:20 -0800 (PST)
To: Yasuo Ohgaki <yohgaki@ohgaki.net>,
 "internals@lists.php.net" <internals@lists.php.net>,
 julien pauli <jpauli@php.net>
References: <CAGa2bXZzvkBDkqLF2U3yPSprQwqBdHbW9QCZ-nzjA1G4CM8QkQ@mail.gmail.com>
Message-ID: <56958637.5080807@gmail.com>
Date: Tue, 12 Jan 2016 15:03:19 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CAGa2bXZzvkBDkqLF2U3yPSprQwqBdHbW9QCZ-nzjA1G4CM8QkQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Fixing bug #68063
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

> I've disallowed empty session ID, but it wasn't a
> appropriate fix.
> 
> https://bugs.php.net/bug.php?id=68063

Could you explain a bit more about the part where there are empty IDs
generated? You say it "is browser's cookie handling" - could you explain
more about it?

> I made appropriate patch for this issue. It should be
> applied from PHP 5.5 to master. I attached patch to
> the bug report. Could you apply it from PHP 5.5? Or
> shall I commit it from 5.6? then cherry pick?

Is that a security issue? If so, please explain how. If not, it should
be 5.6+.

-- 
Stas Malyshev
smalyshev@gmail.com