Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90545
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmx.de designates 212.227.17.21 as permitted sender)
To: Thomas Punt <tpunt@hotmail.co.uk>,
 "internals@lists.php.net" <internals@lists.php.net>
References: <DUB129-W10F0D9A42A48CED194AE98F9FD0@phx.gbl>
 <DUB129-W33FA2120BCCCABAE787016F9CA0@phx.gbl>
Message-ID: <5695044F.1070509@gmx.de>
Date: Tue, 12 Jan 2016 14:49:03 +0100
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <DUB129-W33FA2120BCCCABAE787016F9CA0@phx.gbl>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] [RFC] Number Format Separator
From: cmbecker69@gmx.de (Christoph Becker)

Thomas Punt wrote:

>> I'd like to propose for the inclusion of a digit separator in PHP. This will
>> help to promote the readability of numerical literals in code by enabling for
>> the underscore character to be used in between digits.
>>
>> RFC: https://wiki.php.net/rfc/number_format_separator
>> PR: https://github.com/php/php-src/pull/1699
> 
> Just bringing this back up to the top because of the recent influx in internals
> activity. I'm hoping to put this to vote tomorrow, so if anyone has any
> questions or problems with this RFC, then please let me know!

Thanks for pushing that improvement forward, Tom.

AIUI, digit separators are stripped during lexing, so

  echo 1_000;

will print

  1000

I think it is important to explicitly note that in the RFC.

With regard to "stringy numerics": besides the potential BC break, IMHO
there is no need to support digit separators for string literals at all,
because that could easily be provided by a userland function.  Maybe
it's worth pointing that out in the RFC.

-- 
Christoph M. Becker