Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90518
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain adamharvey.name designates 209.85.217.171 as permitted sender)
MIME-Version: 1.0
Sender: adam@adamharvey.name
In-Reply-To: <5693B6BB.9020607@gmail.com>
References: <CAML1Pf7ti=CG1DRfpPYw0yeyRCUC0ca=ZkKkm3xEHFB_P3_ruw@mail.gmail.com>
 <5693B6BB.9020607@gmail.com>
Date: Mon, 11 Jan 2016 12:15:55 -0800
Message-ID: <CADajX4DWemcKy5ETiSKED+P7bwaQYEU4GdK3TObuAkeFRG8nvw@mail.gmail.com>
To: Rowan Collins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset=UTF-8
Subject: Re: [PHP-DEV] Throwable and Error exceptions break existing PHP 5.x code
From: aharvey@php.net (Adam Harvey)

On 11 January 2016 at 06:05, Rowan Collins <rowan.collins@gmail.com> wrote:
> Since set_exception_handler() is intended as a last-ditch "something's gone
> very wrong" function anyway, I think it receiving all Throwables makes
> sense, even if the BC break in your scenario is unfortunate.

Agreed entirely (as I also said last time this came up). I also don't
want a third path involving a set_throwable_handler() or similar; we
have one too many error handling paths already.

One problematic thing that we _can_ help mitigate is that the first
section of the backward incompatible changes page in the manual starts
with the changes to error and exception handling, but never mentions
this specific issue (type declarations on the exception handler
breaking). That's entirely my fault (I've mentioned it enough in
conference talks that I guess I thought I'd documented it, but
hadn't), and I'll go fix that now.

Adam