Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90492
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 74.125.82.41 as permitted sender)
To: internals@lists.php.net
References: <CAML1Pf7ti=CG1DRfpPYw0yeyRCUC0ca=ZkKkm3xEHFB_P3_ruw@mail.gmail.com>
Message-ID: <5693B6BB.9020607@gmail.com>
Date: Mon, 11 Jan 2016 14:05:47 +0000
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <CAML1Pf7ti=CG1DRfpPYw0yeyRCUC0ca=ZkKkm3xEHFB_P3_ruw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Throwable and Error exceptions break existing PHP 5.x
 code
From: rowan.collins@gmail.com (Rowan Collins)

Giovanni Giacobbi wrote on 11/01/2016 13:31:
> set_exception_handler(callback function, bool also_throwables = false);
>
> The new parameter "also_throwables" defaults to false, so the same
> behaviour as before is preserved. If you want it to catch also the new PHP7
> Error exceptions, you can just set it to true.

This is an interesting idea, but other than the specific transition to 
PHP 7, I'm not sure when it would be used.

Put it this way: if Errors existed when you first wrote this code, would 
you want to handle them using your custom handler functions, or would 
you prefer them to the fall through to the default server White Screen 
of Doom? My guess is that you'd want to pass them to the handler, even 
if it immediately checked "if ($e instanceOf Error)" and used a 
different output style.

Since set_exception_handler() is intended as a last-ditch "something's 
gone very wrong" function anyway, I think it receiving all Throwables 
makes sense, even if the BC break in your scenario is unfortunate.

Regards,
-- 
Rowan Collins
[IMSoP]