Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90483
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.218.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <B55302DA-9269-425B-80C5-059C6EB2C5FC@rouvenwessling.de>
References: <CAKws9z1L7uvBCESKk5espVxYyFtDCMhWuMTTjM5EPciRsk8_zA@mail.gmail.com>
	<B55302DA-9269-425B-80C5-059C6EB2C5FC@rouvenwessling.de>
Date: Mon, 11 Jan 2016 19:27:34 +0700
Message-ID: <CAEZPtU6TXmEMTjnX2B=OwR6cDRrdGQuEaMAxw6DdhOWczohUiw@mail.gmail.com>
To: =?UTF-8?Q?Rouven_We=C3=9Fling?= <me@rouvenwessling.de>
Cc: Scott Arciszewski <scott@paragonie.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary=001a1137d93adeca3c05290e0fa5
Subject: Re: [PHP-DEV] PHP 7.1 - Argon2
From: pierre.php@gmail.com (Pierre Joye)

--001a1137d93adeca3c05290e0fa5
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi,
On Jan 11, 2016 4:12 PM, "Rouven We=C3=9Fling" <me@rouvenwessling.de> wrote=
:
>
>
> > On 11 Jan 2016, at 07:57, Scott Arciszewski <scott@paragonie.com> wrote=
:
> >
> > Does adding Argon2 as a possible choice for password_hash() +
> > password_verify() need an RFC? Or can I just submit a pull request?
>
> The original RFC (https://wiki.php.net/rfc/password_hash) contained the
following text:
>
> > I'd propose the following policy for updating the default hashing
algorithm in future releases of PHP.
> >
> > * Any new algorithm must be in core for at least 1 full release of PHP
prior to becoming default. So if scrypt is added in 5.5.5, it wouldn't be
eligible for default until 5.7 (since 5.6 would be the full release). But
if jcrypt (making it up) was added in 5.6.0, it would also be eligible for
default at 5.7.0.
> > * The default should only change on a full release (5.6.0, 6.0.0, etc)
and not on a revision release. The only exception to this is in an
emergency when a critical security flaw is found in the current default.
> > * For a normal (non-emergency) change in default, an RFC shall be
issued for the update of the default algorithm, following normal RFC rules.
>
> So technically I don=E2=80=99t think it would be necessary to have an RFC=
 to add
another algorithm, though I think it might be nice as this is certainly a
place where things shouldn=E2=80=99t be changed willy nilly.
>
> > It won't be changing the default in 7.1, and IIRC this sort of change
> > was already agreed upon as part of the original password_hash() RFC.
>
> I=E2=80=99m not really qualified to discuss the merits of the algorithm b=
ut a
couple of questions:
>
> * Is there already a crypt scheme for Argon2? Or are there any efforts to
define one? It would good if PHP wouldn=E2=80=99t be an island.

https://github.com/P-H-C/phc-winner-argon2

The reference implementation. If anything we should use it.

I am not sure if we should bundle the library tho'.

> * Back in July, when it won the PHC, it wasn=E2=80=99t deemed production =
ready as
they wanted to make a few tweaks. Is that completed?
> * Are you proposing to use Argon2d or Argon2i?
>
> Lastly, I think it would be a good start to implement Argon2 in ext-hash.
>
> Best regards
> Rouven
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>

--001a1137d93adeca3c05290e0fa5--