Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90477
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: error (pb1.pair.com: domain rouvenwessling.de from 80.241.60.212 cause and error)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 9.1 \(3096.5\))
In-Reply-To: <CAKws9z1L7uvBCESKk5espVxYyFtDCMhWuMTTjM5EPciRsk8_zA@mail.gmail.com>
Date: Mon, 11 Jan 2016 10:12:40 +0100
Cc: PHP Internals <internals@lists.php.net>
Content-Transfer-Encoding: quoted-printable
Message-ID: <B55302DA-9269-425B-80C5-059C6EB2C5FC@rouvenwessling.de>
References: <CAKws9z1L7uvBCESKk5espVxYyFtDCMhWuMTTjM5EPciRsk8_zA@mail.gmail.com>
To: Scott Arciszewski <scott@paragonie.com>
Subject: Re: [PHP-DEV] PHP 7.1 - Argon2
From: me@rouvenwessling.de (=?utf-8?Q?Rouven_We=C3=9Fling?=)


> On 11 Jan 2016, at 07:57, Scott Arciszewski <scott@paragonie.com> =
wrote:
>=20
> Does adding Argon2 as a possible choice for password_hash() +
> password_verify() need an RFC? Or can I just submit a pull request?

The original RFC (https://wiki.php.net/rfc/password_hash) contained the =
following text:

> I'd propose the following policy for updating the default hashing =
algorithm in future releases of PHP.
>=20
> * Any new algorithm must be in core for at least 1 full release of PHP =
prior to becoming default. So if scrypt is added in 5.5.5, it wouldn't =
be eligible for default until 5.7 (since 5.6 would be the full release). =
But if jcrypt (making it up) was added in 5.6.0, it would also be =
eligible for default at 5.7.0.
> * The default should only change on a full release (5.6.0, 6.0.0, etc) =
and not on a revision release. The only exception to this is in an =
emergency when a critical security flaw is found in the current default.
> * For a normal (non-emergency) change in default, an RFC shall be =
issued for the update of the default algorithm, following normal RFC =
rules.

So technically I don=E2=80=99t think it would be necessary to have an =
RFC to add another algorithm, though I think it might be nice as this is =
certainly a place where things shouldn=E2=80=99t be changed willy nilly.=20=


> It won't be changing the default in 7.1, and IIRC this sort of change
> was already agreed upon as part of the original password_hash() RFC.

I=E2=80=99m not really qualified to discuss the merits of the algorithm =
but a couple of questions:

* Is there already a crypt scheme for Argon2? Or are there any efforts =
to define one? It would good if PHP wouldn=E2=80=99t be an island.
* Back in July, when it won the PHC, it wasn=E2=80=99t deemed production =
ready as they wanted to make a few tweaks. Is that completed?
* Are you proposing to use Argon2d or Argon2i?

Lastly, I think it would be a good start to implement Argon2 in =
ext-hash.

Best regards
Rouven=