Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:9047
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
In-Reply-To: <40797364.1010209@sklar.com>
References: <40797364.1010209@sklar.com>
Mime-Version: 1.0 (Apple Message framework v613)
Content-Type: text/plain; charset=US-ASCII; format=flowed
Message-ID: <BD4B5AD5-8C1B-11D8-A341-000A95CE0C62@at.wakwak.com>
Content-Transfer-Encoding: 7bit
Cc: internals@lists.php.net
Date: Mon, 12 Apr 2004 09:52:57 +0900
To: David Sklar <sklar@sklar.com>
Subject: Re: [PHP-DEV] fputcsv()
From: moriyoshi@at.wakwak.com (Moriyoshi Koizumi)


On 2004/04/12, at 1:33, David Sklar wrote:

> Attached is a patch that implements fputcsv() as a complement to 
> fgetcsv().
>
> There are two things that still need improvement:
>
> - It adds "\n" as a newline onto the end of each line. I think it 
> would be better to add a platform-specific line ending.
>
> - It is not mbstring-aware.

As for writing stuff, we don't have to care about in which encoding 
strings
are encoded as long as it is 8-bit compatible. UTF-16 / UTF-32 / UCS-2 /
UCS-4 are not 8-bit compatible and I've never seen a case where one of
these is utilised for CSV files, so I think your code is actually
"multibyte safe" :)

Moriyoshi

>
> Any suggestions for fixing these things (or other issues) would be 
> appreciated.
>
> Thanks,
> David