Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:90463
Mailing-List: contact internals-help@lists.php.net; run by ezmlm
Received-SPF: pass (pb1.pair.com: domain gmail.com designates 209.85.192.172 as permitted sender)
To: Sara Golemon <pollita@php.net>, PHP internals <internals@lists.php.net>
References: <CAESVnVoJBRF3VfKrnWGNCah3KAbxwjacPAwR1HZUC-T-vN=KDQ@mail.gmail.com>
 <CAESVnVqWSh7QQ8Nk+A6Kh5LE1x9naWa=ckoOW-5cQ7GswyUttA@mail.gmail.com>
 <CAESVnVrJ9qa4TWuBw3ALpX-jTAPcVOmO6t3XJtyNCmu-5wO+DQ@mail.gmail.com>
Message-ID: <5692CDAA.4020807@gmail.com>
Date: Sun, 10 Jan 2016 13:31:22 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:38.0)
 Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <CAESVnVrJ9qa4TWuBw3ALpX-jTAPcVOmO6t3XJtyNCmu-5wO+DQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] Re: [RFC] Normalize token_get_all() output (with flag)
From: smalyshev@gmail.com (Stanislav Malyshev)

Hi!

>> A suggestion from a co-worker who's worried about seeing patterns like:
>>
>> case ($t['token']) {
>>   case T_PAAMAYIM_NEKUDOTAYIM:
>>     // do something
>>    break;
>>   case ord(';'):
>>     // do something else
>>     break;
>> }

What's wrong with this pattern? Looks pretty fine to me, clear what's
going on.

>> 2) Make the token field be the character value (for single-character
>> tokens) instead of the ordinal.

That would work too, but the side effect would be mixing types. It
probably not too much trouble since tokens are numbered > 255, but it
may have some unexpected effects that most of the tokens would match by
== 0. Not sure if that's a problem.

>> 3) Add an additional field such that you have Array ( ['id'] => 59,
>> ['token'] => ';', ['text'] => ';', ['line'] => 1 )  'id' would always
>> be integer, while 'token' would be int or single-char.
>>
>> I don't like 3 as it's wasteful and needlessly duplicative.  1 feels a
>> bit over-engineered and actually hurts readability.  2 feels like a

Agree on both 1 and 3.
-- 
Stas Malyshev
smalyshev@gmail.com